Review main Work in progress

91890[WIP][FEATURE] Keep scroll position after content element actions

Dennis Purisevic CR 0 V 0 Normal +90 −4 updated 11/09/26, 07:47

Commit message

Closing an existing content element already returns to the page
module with a #element-tt_content-<uid> anchor. Newly created
elements did not, because their uid only exists after saving, and
deleting or cancelling an element left the editor at the top of
the page.

The return URL now carries an anchor depending on the action:

* Saving and closing a new element: anchor of the new element
* Closing an existing element: anchor of that element
* Deleting an element, or closing a new one without saving: anchor
  of the previous element in the column, none for the first one

The previous element is passed to FormEngine as "previousRecord"
query parameter. Query parameters added to a return URL that
already carries a fragment (id, returnEditConf) stay in the query
string instead of ending up in the fragment.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 7
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/90/91890/7 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/90/91890/7 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 12

Issues 2

Files 3

Review log 1421

  1. Dennis Purisevic uploaded patch set 1 11/26/25, 11:15

  2. core-ci voted on patch set 1 V +1 11/26/25, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91015

  3. Dennis Purisevic uploaded patch set 2 V +1 01/09/26, 17:11

  4. core-ci voted on patch set 2 V -1 01/09/26, 17:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93160

  5. Dennis Purisevic uploaded patch set 3 V -1 01/09/26, 17:22

  6. core-ci voted on patch set 3 V +1 01/09/26, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93162

  7. Simon Schaufelberger commented on patch set 3 02/04/26, 22:36

    Feature-89678-AfterCreatingANewContentElementInPageModuleOrDeletingOneScrollBackToWhereILeft.rst:1

    this file needs to be moved to 14.2
  8. Dennis Purisevic uploaded patch set 4 V +1 02/05/26, 06:07

  9. Dennis Purisevic commented on patch set 4 02/05/26, 06:08

    Feature-89678-AfterCreatingANewContentElementInPageModuleOrDeletingOneScrollBackToWhereILeft.rst:1 Reply

    Done
  10. core-ci voted on patch set 4 V +1 02/05/26, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95105

  11. Thilo Hohl voted on patch set 4 CR +1 09/14/26, 11:15

  12. Thilo Hohl uploaded patch set 5 CR +1 V +1 09/14/26, 11:48

  13. core-ci voted on patch set 5 V +1 09/14/26, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108525

  14. Thilo Hohl rebased onto patch set 6 V +1 11/06/26, 12:34

  15. core-ci voted on patch set 6 V +1 11/06/26, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113507

  16. Garvin Hicking commented on patch set 6 CR -1 11/06/26, 20:04

    Please bear with us here. In main (v15) we're actively working on the formengine handling for save states and "page module" editing.
  17. Dennis Purisevic commented on patch set 6 11/09/26, 06:36

    Reply

    Should I abandon this when it's already worked on?
  18. Garvin Hicking commented on patch set 6 11/09/26, 07:14

    Reply Unresolved

    Maybe just set it to WIP, but abandoned patches could also be restored, yeah....?!
  19. Dennis Purisevic marked it work in progress 11/09/26, 07:36

  20. Dennis Purisevic updated the commit message in patch set 7 CR -1 V +1 11/09/26, 07:39

  21. core-ci voted on patch set 7 V +1 11/09/26, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113628