Review main Merged

91903[BUGFIX] Remove not needed condition in query parser for overlay + floating

David Hedden CR +2 V +2 Easy +0 −4 updated 11/11/26, 13:39

Commit message

The condition was checking for zero in a subquery of UIDs

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. David Hedden uploaded patch set 1 11/27/25, 07:07

  2. David Hedden updated the commit message in patch set 2 11/27/25, 07:13

  3. core-ci voted on patch set 1 V +1 11/27/25, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91066

  4. core-ci voted on patch set 2 V +1 11/27/25, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91067

  5. Stefan Bürk commented on patch set 2 11/27/25, 13:35

    I guess we need first some tests around this area and for the specific case ... maybe the whole construct should be not simply and condition and some nesting (OR) has been missed or similar. Not into that topic, bit I guess this needs more investigation here and some test coverage.
  6. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 07:14

  7. core-ci voted on patch set 3 V -1 04/22/26, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100846

  8. Benni Mack rebased onto patch set 4 V -1 04/26/26, 10:47

  9. core-ci voted on patch set 4 V +1 04/26/26, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101130

  10. Georg Ringer voted on patch set 4 CR +1 V +1 11/10/26, 18:47

  11. Benni Mack commented on patch set 4 CR +2 V +2 11/11/26, 13:39

    Reply

    Done
  12. Benni Mack merged patch set 5 11/11/26, 13:39