#108335Not needed SQL in QueryParser for overlay + floating
Description
I was checking a problem with overlay + floating vs mixed mode. While looking at the complete build SQL i noticed this one:
if ($languageAspect->getOverlayType() === LanguageAspect::OVERLAYS_ON_WITH_FLOATING) {
$andConditions[] = $this->queryBuilder->expr()->and(
$this->queryBuilder->expr()->eq($tableAlias . '.' . $languageField, $languageAspect->getContentId()),
$this->queryBuilder->expr()->eq($tableAlias . '.' . $transOrigPointerField, 0),
$this->queryBuilder->expr()->notIn(
$tableAlias . '.' . $transOrigPointerField,
$defaultLanguageRecordsSubSelect->getSQL()
)
);
}
The 3rd and condition is not needed. If the 2nd is true, the check would look for a record with UID 0.
Reviews 2
Related issues 1
History 38
-
Gerrit Code Review pushed patch set 1 for main to change 91903 status
NewUnder Review <span data-processor="relativetime" data-value="2025-11-27T07:07:11+00:00" > 11/27/25, 07:07 </span> -
Gerrit Code Review pushed patch set 2 for main to change 91903 <span data-processor="relativetime" data-value="2025-11-27T07:13:41+00:00" > 11/27/25, 07:13 </span>
-
David Hedden changed subject
Not need SQL in QueryParser for overlay + floatingNot needed SQL in QueryParser for overlay + floating <span data-processor="relativetime" data-value="2025-11-27T07:39:38+00:00" > 11/27/25, 07:39 </span> -
Gerrit Code Review pushed patch set 3 for main to change 91903 <span data-processor="relativetime" data-value="2026-04-22T07:14:09+00:00" > 04/22/26, 07:14 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 91903 <span data-processor="relativetime" data-value="2026-04-26T10:47:59+00:00" > 04/26/26, 10:47 </span>
-
Alexander Schnitzler changed Related to #110794 <span data-processor="relativetime" data-value="2026-09-25T16:38:56+00:00" > 09/25/26, 16:38 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 97542 <span data-processor="relativetime" data-value="2026-11-11T13:39:33+00:00" > 11/11/26, 13:39 </span>
-
David Hedden commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-11-11T13:45:11+00:00" > 11/11/26, 13:45 </span>
Applied in changeset commit:0d730bccef369b55ac3b8bac14b7e41802c9eca0.