Issue Bug Resolved

#108335Not needed SQL in QueryParser for overlay + floating

David Hedden 11/27/25, 07:04 updated 11/11/26, 13:45

Description

I was checking a problem with overlay + floating vs mixed mode. While looking at the complete build SQL i noticed this one:

        if ($languageAspect->getOverlayType() === LanguageAspect::OVERLAYS_ON_WITH_FLOATING) {
            $andConditions[] = $this->queryBuilder->expr()->and(
                $this->queryBuilder->expr()->eq($tableAlias . '.' . $languageField, $languageAspect->getContentId()),
                $this->queryBuilder->expr()->eq($tableAlias . '.' . $transOrigPointerField, 0),
                $this->queryBuilder->expr()->notIn(
                    $tableAlias . '.' . $transOrigPointerField,
                    $defaultLanguageRecordsSubSelect->getSQL()
                )
            );
        }

The 3rd and condition is not needed. If the 2nd is true, the check would look for a record with UID 0.

Reviews 2

History 38

  1. David Hedden changed subject Not need SQL in QueryParser for overlay + floating Not needed SQL in QueryParser for overlay + floating <span data-processor="relativetime" data-value="2025-11-27T07:39:38+00:00" > 11/27/25, 07:39 </span>

  2. David Hedden commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-11-11T13:45:11+00:00" > 11/11/26, 13:45 </span>

    Applied in changeset commit:0d730bccef369b55ac3b8bac14b7e41802c9eca0.