Review main Ready for review Stale

91937[BUGFIX] Avoid editing inline delete placeholders in workspaces

Torben Hansen CR 0 V 0 Easy +8 −1 updated 07/18/26, 09:11

Commit message

Having custom content elements with nested inline elements
may lead to an error message when deleting an inline
record in a workspace.

When reconstructing `editconf` after saving, the
`EditDocumentController` tries to open the deleted
record in edit mode even if the record has been
versioned as a delete placeholder. Such placeholders
are not editable, leading to broken follow-up editing
in workspace scenarios.

With this change, the controller now checks the
`t3ver_state` of the child record and in case the
record is a delete placeholder, it falls back to
editing the parent record instead.

Additionally this change fixes an PHP undefined array
key warning creating the breadcrumb context for a
new record, when `$this->firstEl['table']` is not set.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 8
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/91937/8 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/91937/8 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 6

Issues 1

Files 1

Review log 1018

  1. Torben Hansen uploaded patch set 1 11/29/25, 14:07

  2. core-ci voted on patch set 1 V -1 11/29/25, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91251

  3. Torben Hansen updated the commit message in patch set 2 V -1 11/29/25, 14:27

  4. core-ci voted on patch set 2 V -1 11/29/25, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91252

  5. Torben Hansen uploaded patch set 3 V -1 11/29/25, 15:18

  6. core-ci voted on patch set 3 V +1 11/29/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91253

  7. Torben Hansen uploaded patch set 4 V +1 11/30/25, 05:13

  8. core-ci voted on patch set 4 V +1 11/30/25, 05:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91291

  9. Christian Kuhn updated the commit message in patch set 5 V +1 12/08/25, 23:23

  10. Christian Kuhn commented on patch set 5 12/08/25, 23:28

    Unresolved

    i understand this fixes the issue. it kinda smells funny and either the reproduce with the inline over inline to tt_content is a bit complex (it should be easier to create such a setup?), or i don't fully understand on why or how this happens in such a scenario only, yet. i'd like to have a deeper look to understand details in order to see if the record query is *really* needed here since that may(?) become expensive when many inline children are attached?
  11. core-ci voted on patch set 5 V +1 12/08/25, 23:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91839

  12. Torben Hansen uploaded patch set 6 V +1 02/14/26, 11:01

  13. core-ci voted on patch set 6 V +1 02/14/26, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95885

  14. Benni Mack updated the commit message in patch set 7 V +1 04/22/26, 06:43

  15. core-ci voted on patch set 7 V -1 04/22/26, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100771

  16. Christian Kuhn wrote 06/18/26, 23:04

    Removed cc Christian Kuhn.
  17. Torben Hansen rebased onto patch set 8 V -1 07/18/26, 09:03

  18. core-ci voted on patch set 8 V +1 07/18/26, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104938