91994[TASK] Make use of proper formated XLIFF files more robust
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 24
- typo3/sysext/core/Classes/Localization/Loader/XliffLoader.php+17 −13
- typo3/sysext/core/Classes/Localization/LabelFileResolver.php+9 −5
- typo3/sysext/core/Classes/Localization/LanguageService.php+1 −0
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+18 −15
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/default-with-targets/fr.locallang.xlfnew+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/default-with-targets/locallang.xlfnew+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/override-without-targets/locallang_common_override.xlfnew+17 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/override-without-targets/locallang_override.xlfnew+14 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/de.locallang_override.xlf+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/fr.locallang.xlf+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/fr.locallang_override.xlf+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/locallang_common_override.xlf+7 −4
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/locallang_override.xlf+5 −3
- typo3/sysext/core/Tests/Functional/Localization/LanguageServiceTest.php+39 −0
- typo3/sysext/core/Tests/Unit/Localization/Loader/Fixtures/de.locallang-v2--invalid_without_sources.xlfnew+20 −0
- typo3/sysext/core/Tests/Unit/Localization/Loader/Fixtures/de.locallang-v2--original_without_targets.xlfnew+20 −0
- typo3/sysext/core/Tests/Unit/Localization/Loader/Fixtures/de.locallang-v2.xlf+4 −1
- typo3/sysext/core/Tests/Unit/Localization/Loader/Fixtures/fr.locallang-v2.xlf+1 −1
- typo3/sysext/core/Tests/Unit/Localization/Loader/Fixtures/fr.locallang.xlf+1 −1
- typo3/sysext/core/Tests/Unit/Localization/Loader/Fixtures/locallang--based_on_non_english_with_targets.xlfnew+20 −0
Show 4 more files
- typo3/sysext/core/Tests/Unit/Localization/Loader/Fixtures/locallang.xlf+1 −1
- typo3/sysext/core/Tests/Unit/Localization/Loader/XliffLoaderTest.php+61 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/label_test/Resources/Private/Language/ru.locallang.xlf+1 −1
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/Language/fr.page.xlf+1 −1
Review log 2645
Show 1120 earlier messages
-
Ayke Halder uploaded patch set 1 12/03/25, 09:35
-
core-ci voted on patch set 1 V -1 12/03/25, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91510
-
Ayke Halder uploaded patch set 2
V -112/03/25, 10:17 -
Lina Wolf commented on patch set 2 12/03/25, 10:22
What would happen if XLIFF 2.0 is used? Can you add a test for that as well? -
core-ci voted on patch set 2 V -1 12/03/25, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91512
-
Ayke Halder uploaded patch set 3
V -112/03/25, 11:55 -
core-ci voted on patch set 3 V -1 12/03/25, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91524
-
Ayke Halder uploaded patch set 4
V -112/03/25, 15:09 -
core-ci voted on patch set 4 V -1 12/03/25, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91541
-
Ayke Halder uploaded patch set 5
V -112/03/25, 18:15 -
core-ci voted on patch set 5 V +1 12/03/25, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91545
-
Ayke Halder updated the commit message in patch set 6
V +112/03/25, 18:57 -
Ayke Halder marked it ready for review 12/03/25, 18:57
-
core-ci voted on patch set 6 V +1 12/03/25, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91546
-
Ayke Halder uploaded patch set 7
V +112/03/25, 20:28 -
core-ci voted on patch set 7 V +1 12/03/25, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91551
-
Ayke Halder uploaded patch set 8
V +112/03/25, 20:40 -
core-ci voted on patch set 8 V -1 12/03/25, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91552
-
Ayke Halder uploaded patch set 9
V -112/03/25, 21:24 -
core-ci voted on patch set 9 V +1 12/03/25, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91553
-
Ayke Halder uploaded patch set 10
V +112/12/25, 14:21 -
core-ci voted on patch set 10 V -1 12/12/25, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92149
-
Ayke Halder uploaded patch set 11
V -112/12/25, 14:31 -
Ayke Halder uploaded patch set 12 12/12/25, 14:35
-
Ayke Halder commented on patch set 12 12/12/25, 14:36
Reply
-
core-ci voted on patch set 11 V -1 12/12/25, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92151
-
core-ci voted on patch set 12 V +1 12/12/25, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92152
-
Ayke Halder uploaded patch set 13
V +112/12/25, 15:34 -
core-ci voted on patch set 13 V -1 12/12/25, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92155
-
Ayke Halder uploaded patch set 14
V -112/12/25, 16:32 -
core-ci voted on patch set 14 V -1 12/12/25, 16:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92156
-
Ayke Halder uploaded patch set 15
V -112/12/25, 17:10 -
core-ci voted on patch set 15 V -1 12/12/25, 17:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92158
-
Ayke Halder uploaded patch set 16
V -112/12/25, 17:56 -
core-ci voted on patch set 16 V -1 12/12/25, 18:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92160
-
Ayke Halder uploaded patch set 17
V -112/12/25, 18:16 -
core-ci voted on patch set 17 V +1 12/12/25, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92161
-
Ayke Halder rebased onto patch set 18
V +112/22/25, 15:59 -
core-ci voted on patch set 18 V +1 12/22/25, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92585
-
Benni Mack voted on patch set 18 CR +1 V +1 12/23/25, 07:01
-
Josef Glatz updated the commit message in patch set 19
CR +1V +112/28/25, 15:07 -
core-ci voted on patch set 19 V +1 12/28/25, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92755
-
Benni Mack voted on patch set 19 CR +1 V +1 12/28/25, 15:25
-
Georg Ringer voted on patch set 19 CR +2 V +2 01/19/26, 13:09
-
Georg Ringer merged patch set 20 01/19/26, 13:09