Review 13.4 Merged

92042[BUGFIX] Correctly check for TSconfig boolean setting

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 12/08/25, 20:24

Commit message

The TSconfig option `checkhidden` is always passed as string to PHP. So
we cannot use a type-safe check against an integer.

This patch uses the same implementation as in all the other
cases of the same extension, by checking for a boolean `true`.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 12/08/25, 19:35

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/08/25, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91834

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 12/08/25, 20:24

  4. Garvin Hicking merged patch set 2 12/08/25, 20:24