Review main Merged

92094[BUGFIX] Properly throw ValueError in locallang translate handling

Garvin Hicking CR +2 V +2 Easy +28 −1 updated 12/11/25, 14:00

Commit message

With #107686, `sprintf()` usage was replaced with `vsprintf()` to
deal with failing argument errors and untranslateable labels.

However instead of throwing/forwarding the ValueError to consumers,
a `return` was utilized.

This patch properly throws, which allows to not fatally bail on
language labels. More tests are added to cover these scenarios.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 5

Files 3

Review log 911

  1. Garvin Hicking uploaded patch set 1 12/10/25, 18:51

  2. Garvin Hicking commented on patch set 1 12/10/25, 18:54

    We should discuss if we want any of this fault-tolerant behaviour in v13 (I would say: yes). Doing changes like this in v12 is IMO out of scope now and too impactful.
  3. core-ci voted on patch set 1 V -1 12/10/25, 18:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92017

  4. Benni Mack commented on patch set 2 V -1 12/10/25, 19:55

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V +1 12/10/25, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92019

  6. Benni Mack commented on patch set 2 12/10/25, 20:21

    Reply

    This is at another place then, or on some multiple places. If we fix this in v13, this will be in a much different place.
  7. Garvin Hicking commented on patch set 2 12/10/25, 20:59

    Reply

    I'm happy to focus on main for now.
  8. Benni Mack voted on patch set 2 CR +1 V +1 12/11/25, 06:42

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 12/11/25, 13:54

  10. Garvin Hicking voted on patch set 2 CR +2 V +2 12/11/25, 13:59

  11. Garvin Hicking merged patch set 3 12/11/25, 14:00