92094[BUGFIX] Properly throw ValueError in locallang translate handling
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 5
- Bug #108466Properly throw ValueError in locallang translate handling
- Bug #108427TYPO3 backend login broken when xlf file not translated properly
- Bug #108424Backend login crashes with ValueError in sprintf() when German translation is used (invalid format string for free_software_and_warranty)
- Task #107686Move more code from Extbase/Form into LanguageService
- Task #107436Add symfony/translation component
Files 3
Review log 911
-
Garvin Hicking uploaded patch set 1 12/10/25, 18:51
-
Garvin Hicking commented on patch set 1 12/10/25, 18:54
We should discuss if we want any of this fault-tolerant behaviour in v13 (I would say: yes). Doing changes like this in v12 is IMO out of scope now and too impactful. -
core-ci voted on patch set 1 V -1 12/10/25, 18:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92017
-
Benni Mack commented on patch set 2
V -112/10/25, 19:55Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 12/10/25, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92019
-
Benni Mack commented on patch set 2 12/10/25, 20:21
Reply
This is at another place then, or on some multiple places. If we fix this in v13, this will be in a much different place. -
Garvin Hicking commented on patch set 2 12/10/25, 20:59
Reply
I'm happy to focus on main for now. -
Benni Mack voted on patch set 2 CR +1 V +1 12/11/25, 06:42
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 12/11/25, 13:54
-
Garvin Hicking voted on patch set 2 CR +2 V +2 12/11/25, 13:59
-
Garvin Hicking merged patch set 3 12/11/25, 14:00