Review 13.4 Merged

92160[TASK] Reflect `non-empty-string` return type in `HashScope::prefix()`

Christian Kuhn CR +2 V +2 Easy +6 −0 updated 12/18/25, 13:48

Commit message

The `HashScope::prefix()` methods from EXT:form and EXT:extbase always
return a non-empty string. Since the return values of these methods are
commonly used for HMAC validation secrets, which are required to be
non-empty, appropriate PHPDoc return types are added to said methods.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn commented on patch set 1 12/18/25, 13:33

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/18/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92418

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 12/18/25, 13:48

  4. Christian Kuhn merged patch set 2 12/18/25, 13:48