Review main Merged

92212[TASK] Rename $hash to $hashAlgorithm

Christian Weiske CR +2 V +2 Easy +4 −4 updated 12/24/25, 16:42

Commit message

The variable $hash in some ResourceStorage method signatures does
not mean "$hash" but "$hashAlgorithm", which is slightly confusing.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Weiske uploaded patch set 1 12/23/25, 07:38

  2. Oliver Klee voted on patch set 1 CR +1 V +1 12/23/25, 07:39

  3. core-ci voted on patch set 1 V +1 12/23/25, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92605

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 12/23/25, 09:35

  5. Guido Schmechel voted on patch set 1 CR +1 V +1 12/24/25, 12:48

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 12/24/25, 16:17

  7. Christian Kuhn merged patch set 2 12/24/25, 16:42