#108566ResourceStorage: $hash sometimes means $hashAlgorithm
Description
The variable $hash in the following ResourceStorage method signatures does not mean $hash but $hashAlgorithm:
public function hashFile(FileInterface $fileObject, string $hash): string
public function hashFileByIdentifier(string $fileIdentifier, string $hash): string
This is slightly confusing, especially when it is overridden with a real hash:
public function hashFileByIdentifier(string $fileIdentifier, string $hash): string
{
$hash = $this->driver->hash($fileIdentifier, $hash);Reviews 2
History 25
-
Gerrit Code Review pushed patch set 1 for main to change 92212 status
NewUnder Review <span data-processor="relativetime" data-value="2025-12-23T07:38:55+00:00" > 12/23/25, 07:38 </span> -
Gerrit Code Review pushed patch set 1 for 13.4 to change 92225 <span data-processor="relativetime" data-value="2025-12-24T16:14:29+00:00" > 12/24/25, 16:14 </span>
-
Gerrit Code Review pushed patch set 2 for 13.4 to change 92225 <span data-processor="relativetime" data-value="2025-12-24T16:16:42+00:00" > 12/24/25, 16:16 </span>
-
Anonymous commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-12-24T16:45:07+00:00" > 12/24/25, 16:45 </span> -
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2026-03-31T08:59:38+00:00" > 03/31/26, 08:59 </span>
Applied in changeset commit:fddec31330f196d42f8128f31749804c1324050a.