Review 12.4 Merged

92344[BUGFIX] Allow AbstractPart and File in spooled email deserialization

Markus Klein CR +2 V +2 Normal +111 −30 updated 01/19/26, 09:43

Commit message

The FileSpool deserialization previously failed when processing complex
emails containing Symfony Mime AbstractPart or File objects, causing
valid messages to be rejected and deleted. This adds AbstractPart and
File to the allowed classes list in the PolymorphicDeserializer.

Additionally, improve error handling by preserving failed messages:
- Rename deserialization failures to ".invalid" instead of deleting
- Retain ".sending" files when transport fails (allows retry)
- Include original exception details in error logs for debugging

This enables proper handling of emails with attachments, embedded
files, and complex MIME structures while improving troubleshooting
capabilities through better error preservation and logging.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 1117

  1. Markus Klein commented on patch set 1 01/15/26, 14:40

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 01/15/26, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93523

  3. Markus Klein commented on patch set 2 V -1 01/15/26, 16:10

    Cherry Picked from branch main.
  4. core-ci voted on patch set 2 V +1 01/15/26, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93530

  5. Markus Klein commented on patch set 2 CR -1 V -1 01/16/26, 09:10

    more changes in main
  6. Markus Klein commented on patch set 3 CR -1 V +1 01/16/26, 09:54

    Cherry Picked from branch main.
  7. core-ci voted on patch set 3 V +1 01/16/26, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93573

  8. Markus Klein commented on patch set 4 V +1 01/16/26, 10:17

    Cherry Picked from branch main.
  9. core-ci voted on patch set 4 V -1 01/16/26, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93583

  10. Oliver Hader commented on patch set 4 CR -1 01/16/26, 12:18

    Needs to be synced with `main` patch
  11. Markus Klein uploaded patch set 5 CR -1 V -1 01/16/26, 12:59

  12. Markus Klein commented on patch set 5 01/16/26, 13:00

    Reply

    Done
  13. core-ci voted on patch set 5 V +1 01/16/26, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93603

  14. Benjamin Franzke uploaded patch set 6 V +1 01/19/26, 07:48

  15. core-ci voted on patch set 6 V +1 01/19/26, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93753

  16. Benjamin Franzke voted on patch set 6 CR +2 V +2 01/19/26, 07:55

  17. Benjamin Franzke merged patch set 7 01/19/26, 09:43