Review main Ready for review Stale

92366[BUGFIX] Synchronize inline relation pids when parent pid changes

Benni Mack CR 0 V -1 Normal +106 −1 updated 09/02/26, 05:04

Commit message

When changing a parent record's pid via Extbase persistence, inline
child records (1:n relations with foreign_field) did not get
their pid synchronized. This is different from FormEngine/DataHandler
behavior, leaving child records on the original page and potentially
inaccessible to users without proper permissions.

The change adds pid change detection in persistObject() and a new method
synchronizeInlineRelationPids() that updates the pid of all inline
child records when the parent's pid changes.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/66/92366/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/66/92366/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 4

Issues 1

Files 3

Review log 69

  1. Benni Mack uploaded patch set 1 01/17/26, 19:53

  2. core-ci voted on patch set 1 V +1 01/17/26, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93686

  3. Benni Mack marked it ready for review 05/04/26, 14:00

  4. Benni Mack rebased onto patch set 2 V +1 05/04/26, 14:00

  5. core-ci voted on patch set 2 V +1 05/04/26, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101468

  6. Oliver Klee voted on patch set 2 V +1 05/05/26, 07:18

  7. Anja Leichsenring commented on patch set 2 05/05/26, 11:49

    how does this work, if `useCombination' => true,` is set, or the PID prepared with `TCAdefaults.<table>.pid = <page id>`? Both cases must probably be left alone, only real one-way-children should move with the parent.
  8. Benni Mack rebased onto patch set 3 V +1 09/02/26, 04:53

  9. core-ci voted on patch set 3 V -1 09/02/26, 05:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107554