Review 13.4 Merged

92369[TASK] Remove attribute space='preserve' from xlf files

Benni Mack CR +2 V +2 Expert +676 −676 updated 01/18/26, 08:57

Commit message

The attribute `xml:space="preserve"` must only be used if the spaces
are relevant and must be preserved. Even though there is no official
support for the attribute, it should be used correctly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 57

  1. Benni Mack commented on patch set 1 01/18/26, 08:40

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf * typo3/sysext/backend/Resources/Private/Language/locallang_toolbar.xlf * typo3/sysext/core/Resources/Private/Language/locallang_core.xlf * typo3/sysext/core/Resources/Private/Language/locallang_mfa_provider.xlf * typo3/sysext/core/Resources/Private/Language/locallang_tsfe.xlf * typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf * typo3/sysext/dashboard/Resources/Private/Language/locallang_widget_rss.xlf * typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf * typo3/sysext/felogin/Resources/Private/Language/locallang.xlf * typo3/sysext/form/Resources/Private/Language/Database.xlf * typo3/sysext/form/Resources/Private/Language/locallang.xlf * typo3/sysext/form/Resources/Private/Language/locallang_formEditor_failSafeErrorHandling_javascript.xlf * typo3/sysext/form/Resources/Private/Language/locallang_formManager_javascript.xlf * typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_labels/Resources/Private/Language/de.locallang_form.xlf * typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_labels/Resources/Private/Language/de.locallang_text.xlf * typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_additional_text.xlf * typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_ceuid_suffix_01.xlf * typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_ceuid_suffix_02.xlf * typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_empty_values.xlf * typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_form.xlf * typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_form_overrides.xlf * typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_labels/Resources/Private/Language/locallang_text.xlf * typo3/sysext/impexp/Resources/Private/Language/db.xlf * typo3/sysext/install/Resources/Private/Language/Report/locallang.xlf * typo3/sysext/sys_note/Resources/Private/Language/locallang_widget_pages_with_internal_note.xlf * typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf
  2. Benni Mack uploaded patch set 2 01/18/26, 08:49

  3. Benni Mack marked it ready for review 01/18/26, 08:49

  4. core-ci voted on patch set 1 V -1 01/18/26, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93712

  5. core-ci voted on patch set 2 V +1 01/18/26, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93713

  6. Benni Mack voted on patch set 2 CR +2 V +2 01/18/26, 08:57

  7. Benni Mack merged patch set 3 01/18/26, 08:57