Review 13.4 Merged

92413[TASK] Update PHPStan to 2.1.34

Garvin Hicking CR +2 V +2 Normal +29 −32 updated 01/20/26, 14:59

Commit message

Executed commands:

    composer req --dev phpstan/phpstan:^2.1.34 -W
   ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

- Adjusted @param-out effects
- Remove unneeded empty() check
- Replace wording of already ignored baseline
- Removed superfluous check for language aware schema

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 711

  1. Garvin Hicking commented on patch set 1 01/20/26, 06:24

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.lock
  2. core-ci voted on patch set 1 V -1 01/20/26, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93829

  3. Garvin Hicking uploaded patch set 2 V -1 01/20/26, 07:26

  4. core-ci voted on patch set 2 V +1 01/20/26, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93840

  5. Garvin Hicking updated the commit message in patch set 3 V +1 01/20/26, 07:34

  6. core-ci voted on patch set 3 V +1 01/20/26, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93842

  7. Garvin Hicking uploaded patch set 4 V +1 01/20/26, 08:07

  8. Garvin Hicking marked it ready for review 01/20/26, 08:08

  9. core-ci voted on patch set 4 V +1 01/20/26, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93847

  10. Garvin Hicking voted on patch set 4 CR +2 V +2 01/20/26, 14:59

  11. Garvin Hicking merged patch set 5 01/20/26, 14:59