Review 12.4 Merged

92414[TASK] Update PHPStan to 2.1.34

Garvin Hicking CR +2 V +2 Easy +9 −10 updated 01/20/26, 17:58

Commit message

Executed commands:

    composer req --dev phpstan/phpstan:^2.1.34 -W
   ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

- Adjusted @param-out effects
- Remove unneeded empty() check
- Replace wording of already ignored baseline
- Removed superfluous check for language aware schema

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Garvin Hicking commented on patch set 1 01/20/26, 06:24

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.json * composer.lock * typo3/sysext/styleguide/Classes/TcaDataGenerator/Generator.php
  2. core-ci voted on patch set 1 V -1 01/20/26, 06:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93830

  3. Garvin Hicking uploaded patch set 2 V -1 01/20/26, 07:33

  4. core-ci voted on patch set 2 V +1 01/20/26, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93841

  5. Garvin Hicking uploaded patch set 3 V +1 01/20/26, 08:06

  6. Garvin Hicking marked it ready for review 01/20/26, 08:08

  7. core-ci voted on patch set 3 V +1 01/20/26, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93846

  8. Garvin Hicking voted on patch set 3 CR +2 V +2 01/20/26, 15:00

  9. Garvin Hicking merged patch set 4 01/20/26, 17:58