Review main Merged

92480[BUGFIX] Resolve XLIFF files for locale with language and country code

Ayke Halder CR +2 V +2 Easy +1 −1 updated 01/23/26, 15:20

Commit message

This patch correctly resolves XLIFF files for locales with language and
country code like `fr_CA`.

Before files like `fr_CA.locallang.xlf` (underscore) did not get
resolved. Only files like `fr-CA.locallang.xlf` (dash) did fine.
This was introduced by [1] and is also already resolved by [2].

Before files given with absolute paths like
`/var/www/…/vendor/foo/bar/Resources/Private/Language/locallang.xlf`
did not get resolved to the locale file `fr-CA.locallang.xlf`. Instead
the given absolute path and thereby english localization was used.
This was introduced by [3] and slightly disarmed for composer based
package paths by [2].
For a in detail explanation see commit message of [3].

[1] Ic75447bb54804ea56c21d858ccfb133c146798ff
[2] I4beb7895dd971acbc32c971cf60aee84b54a87a6
[3] I78bf3166c51f78244c7125f77a82e5eb9fe6a66c

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 4

Files 1

Review log 69

  1. Ayke Halder uploaded patch set 1 01/23/26, 11:45

  2. core-ci voted on patch set 1 V +1 01/23/26, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94158

  3. Ayke Halder uploaded patch set 2 V +1 01/23/26, 14:24

  4. core-ci voted on patch set 2 V +1 01/23/26, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94176

  5. Ayke Halder updated the commit message in patch set 3 V +1 01/23/26, 15:12

  6. core-ci voted on patch set 3 V +1 01/23/26, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94182

  7. Garvin Hicking voted on patch set 3 CR +1 V +1 01/23/26, 15:20

  8. Benni Mack voted on patch set 3 CR +2 V +2 01/23/26, 15:20

  9. Benni Mack merged patch set 4 01/23/26, 15:20