Review 13.4 Merged

92496[BUGFIX] Consider xclassed domain model in extbase file upload

Garvin Hicking CR +2 V +2 Normal +118 −1 updated 01/24/26, 21:38

Commit message

The Extbase fileupload feature does not take into account
that a domain model can be extended via xclass. Therefore,
the file upload annotation/attribute is not processed
and uploading files for properties of the extended domain
model will fail.

This change fixes the problem by resolving a possible
extended domain model in `FileHandlingService` for the
current processed attribute via
`GeneralUtility::getClassName()`.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Garvin Hicking commented on patch set 1 01/24/26, 16:41

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 01/24/26, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94265

  3. Garvin Hicking commented on patch set 1 01/24/26, 16:52

    Will do backport a bit later. Needs attribute/annotation replacement in v13.
  4. Garvin Hicking commented on patch set 1 01/24/26, 16:54

    ModelWithTextfield.php:20

    here

    ModelWithTextfield.php:25

    Array syntax here

    XClassForModelWithTextfield.php:20

    here

    XClassForModelWithTextfield.php:26

    Array here
  5. Garvin Hicking uploaded patch set 2 V -1 01/24/26, 21:07

    adjust backport
  6. core-ci voted on patch set 2 V +1 01/24/26, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94270

  7. Garvin Hicking commented on patch set 2 CR +2 V +2 01/24/26, 21:38

    ModelWithTextfield.php:20 Reply

    Done

    ModelWithTextfield.php:25 Reply

    Done

    XClassForModelWithTextfield.php:20 Reply

    Done

    XClassForModelWithTextfield.php:26 Reply

    Done
  8. Garvin Hicking commented on patch set 2 01/24/26, 21:38

    Reply

    Done
  9. Garvin Hicking merged patch set 3 01/24/26, 21:38