Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
92509[WIP][BUGFIX] Fix memory leak in content-navigation-toggle
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/92509/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/92509/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Relation chain 2
-
92509 [WIP][BUGFIX] Fix memory leak in content-navigation-toggle This change
-
main
81409[WIP][TASK] Use @lit/context for color scheme and theme state management
The chain has patch set 20 of 21, the changes above it need a rebase.
Issues 1
Files 6
- Build/Sources/TypeScript/backend/context/content-navigation.tsnew+16 −0
- Build/Sources/TypeScript/backend/viewport/content-navigation-toggle.ts+37 −176
- Build/Sources/TypeScript/backend/viewport/content-navigation.ts+24 −22
- typo3/sysext/backend/Resources/Public/JavaScript/context/content-navigation.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/viewport/content-navigation-toggle.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/viewport/content-navigation.js+1 −1
Review log 36
-
Benjamin Franzke uploaded patch set 1 01/26/26, 07:44
-
core-ci voted on patch set 1 V +1 01/26/26, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94340
-
Benjamin Franzke uploaded patch set 2
V +101/26/26, 08:18 -
core-ci voted on patch set 2 V +1 01/26/26, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94344
-
Benjamin Franzke uploaded patch set 3
V +101/26/26, 08:44 -
core-ci voted on patch set 3 V -1 01/26/26, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94346