Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

92509[WIP][BUGFIX] Fix memory leak in content-navigation-toggle

Benjamin Franzke CR 0 V -1 Hard +92 −200 updated 01/26/26, 08:53

Commit message

Binding events to `top.document` from an iframe
cause massive memory leaks, as the iframe document
stays in memory (as detached DOM elements) forever
(until the tab closes, or another website is opened).

Instead of building an own context management solution,
@lit/context is now used to synchronize state between
the content-navigation element and the corresponding
toggle buttons.

TODO:
 * Figure out why a resize observer was used
 * Verify if this resolves all leaks that have been introduced
   with #108468
   (noticeable by a constant DOM node increase when switching between
   two simple backend modules)

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/92509/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/92509/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Relation chain 2

  1. 92509 [WIP][BUGFIX] Fix memory leak in content-navigation-toggle This change

  2. main 81409[WIP][TASK] Use @lit/context for color scheme and theme state management This change is based on it Work in progress Merge conflict Benjamin Franzke CR 0 V 0 Hard +327 −73

    The chain has patch set 20 of 21, the changes above it need a rebase.

Issues 1

Files 6

Review log 36

  1. Benjamin Franzke uploaded patch set 1 01/26/26, 07:44

  2. core-ci voted on patch set 1 V +1 01/26/26, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94340

  3. Benjamin Franzke uploaded patch set 2 V +1 01/26/26, 08:18

  4. core-ci voted on patch set 2 V +1 01/26/26, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94344

  5. Benjamin Franzke uploaded patch set 3 V +1 01/26/26, 08:44

  6. core-ci voted on patch set 3 V -1 01/26/26, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94346