Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Stale

81409[WIP][TASK] Use @lit/context for color scheme and theme state management

Benjamin Franzke CR 0 V 0 Hard +327 −73 updated 09/10/26, 11:29

Commit message

Introduce a new backend container element called `<typo3-backend>`
that provides states for elements (like the light/dark) toggle
that rely on global state and therefore want to consume
state.

The management part of the color and theme switch is thus
moved from the user settings manager – which should only
take care of managing data, not *how* to apply them,
to this new container element.

Commands executed:

  npm install @lit/context
  npm run build

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 21
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/81409/21 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/81409/21 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 5

  1. main 92509[WIP][BUGFIX] Fix memory leak in content-navigation-toggle Based on this change Work in progress Merge conflict Benjamin Franzke CR 0 V -1 Hard +92 −200
  2. main 91441[WIP][TASK] Provide module state as context via <typo3-backend> Based on this change Work in progress Merge conflict Benjamin Franzke CR 0 V 0 Normal +97 −62
  3. main 81598[TASK] Migrate icon-element to @lit/task Based on this change Merged Benjamin Franzke CR +2 V +2 → 12.4 Hard +350 −113

    The chain has patch set 4 of 8, the changes above it need a rebase.

  4. main 81597[BUGFIX] Allow custom AbortSignal to be passed to AjaxRequest methods Based on this change Merged Benjamin Franzke CR +2 V +2 → 12.4 Easy +22 −2

    The chain has patch set 1 of 3, the changes above it need a rebase.

  5. 81409 [WIP][TASK] Use @lit/context for color scheme and theme state management This change

Issues 1

Files 34

Show 14 more files

Review log 2343

Show 1118 earlier messages
  1. Benjamin Franzke uploaded patch set 1 10/11/23, 03:37

  2. core-ci voted on patch set 1 V +1 10/11/23, 03:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47672

  3. Benjamin Franzke uploaded patch set 2 V +1 10/27/23, 13:52

  4. core-ci voted on patch set 2 V +1 10/27/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48292

  5. Benjamin Franzke uploaded patch set 3 V +1 11/02/23, 19:29

  6. core-ci voted on patch set 3 V +1 11/02/23, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48513

  7. Benjamin Franzke marked it work in progress 11/03/23, 09:07

  8. Oliver Hader updated the commit message in patch set 4 V +1 10/18/24, 14:08

  9. Benjamin Franzke uploaded patch set 5 02/11/25, 11:57

  10. core-ci voted on patch set 5 V -1 02/11/25, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73974

  11. Benjamin Franzke uploaded patch set 6 V -1 02/28/25, 14:55

  12. core-ci voted on patch set 6 V -1 02/28/25, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74903

  13. Benjamin Franzke uploaded patch set 7 V -1 03/03/25, 11:55

  14. core-ci voted on patch set 7 V +1 03/03/25, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75011

  15. Benjamin Franzke uploaded patch set 8 V +1 06/24/25, 14:26

  16. core-ci voted on patch set 8 V +1 06/24/25, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80745

  17. Benjamin Franzke uploaded patch set 9 V +1 11/06/25, 08:11

  18. Benjamin Franzke uploaded patch set 10 11/06/25, 08:14

  1. Benjamin Franzke uploaded patch set 11 11/06/25, 08:17

  2. core-ci voted on patch set 9 V -1 11/06/25, 08:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88551

  3. Benjamin Franzke uploaded patch set 12 11/06/25, 08:21

  4. core-ci voted on patch set 10 V -1 11/06/25, 08:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88552

  5. core-ci voted on patch set 11 V -1 11/06/25, 08:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88553

  6. Benjamin Franzke uploaded patch set 13 11/06/25, 08:29

  7. core-ci voted on patch set 12 V -1 11/06/25, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88554

  8. core-ci voted on patch set 13 V +1 11/06/25, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88556

  9. Benjamin Franzke uploaded patch set 14 V +1 11/06/25, 19:06

  10. core-ci voted on patch set 14 V +1 11/06/25, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88601

  11. Benjamin Franzke uploaded patch set 15 V +1 11/06/25, 19:17

  12. core-ci voted on patch set 15 V +1 11/06/25, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88602

  13. Benjamin Franzke uploaded patch set 16 V +1 11/06/25, 21:18

  14. core-ci voted on patch set 16 V +1 11/06/25, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88604

  15. Benjamin Franzke uploaded patch set 17 V +1 11/06/25, 21:40

  16. core-ci voted on patch set 17 V +1 11/06/25, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88605

  17. Benjamin Franzke uploaded patch set 18 V +1 11/07/25, 10:33

  18. core-ci voted on patch set 18 V -1 11/07/25, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88638

  19. Benjamin Franzke uploaded patch set 19 V -1 11/07/25, 10:49

  20. core-ci voted on patch set 19 V +1 11/07/25, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88640

  21. Benjamin Franzke marked it work in progress 11/07/25, 11:30

  22. Benjamin Franzke uploaded patch set 20 V +1 01/26/26, 07:32

  23. core-ci voted on patch set 20 V +1 01/26/26, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94339

  24. Benjamin Franzke uploaded patch set 21 V +1 09/10/26, 11:21

  25. core-ci voted on patch set 21 V +1 09/10/26, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108251