Review main Merged

92590[BUGFIX] Evaluate only the workspace version for page preview flag

Amir Arends CR +2 V +2 Normal +50 −5 updated 11/11/26, 15:36

Commit message

When a page is hidden in live but visible in a workspace,
PageRepository::checkIfPageIsHidden() reported it as hidden. The
PreviewSimulator then enabled "includeHiddenPages" for the whole
workspace preview, so other hidden pages showed up in menus and
rootlines as well.

In a workspace, only the workspace version of a page - or the live
page if there is no workspace version - decides whether the page is
hidden. getWorkspaceVersionOfRecord() already checks exactly that
record with the RecordAccessVoter, so its -1 and -2 results are
sufficient.

A page uid that does not exist no longer causes a TypeError in a
workspace context.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Amir Arends +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Amir Arends +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1116

  1. Amir Arends uploaded patch set 1 01/30/26, 14:48

  2. core-ci voted on patch set 1 V -1 01/30/26, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94680

  3. Amir Arends uploaded patch set 2 V -1 01/30/26, 15:11

  4. core-ci voted on patch set 2 V +1 01/30/26, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94683

  5. Amir Arends rebased onto patch set 3 V +1 02/04/26, 12:47

  6. core-ci voted on patch set 3 V +1 02/04/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95015

  7. Benni Mack updated the commit message in patch set 4 V +1 04/22/26, 06:40

  8. core-ci voted on patch set 4 V -1 04/22/26, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100757

  9. Benni Mack uploaded patch set 5 V -1 11/09/26, 21:28

  10. Benni Mack voted on patch set 5 CR +1 V +1 11/09/26, 21:36

  11. core-ci voted on patch set 5 V +1 11/09/26, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113801

  12. Amir Arends voted on patch set 5 CR +1 11/09/26, 21:44

  13. Amir Arends voted on patch set 5 V +1 11/09/26, 21:46

  14. Josua Vogel voted on patch set 5 CR +1 V +1 11/11/26, 14:56

  15. Benni Mack voted on patch set 5 CR +2 V +2 11/11/26, 15:36

  16. Benni Mack merged patch set 6 11/11/26, 15:36