#108814Workspace preview ignores content element hidden state when page is hidden in LIVE
Description
When a page is hidden=1 in LIVE but hidden=0 in a workspace, content elements that are deliberately hidden in the workspace are still rendered visible in the workspace preview.
Root cause: PageRepository::checkIfPageIsHidden() (line ~2139) checks both the workspace version AND the live version:
$isHidden = !$accessVoter->accessGranted('pages', $versionedPage, $alternativeContext) || !$accessVoter->accessGranted('pages', $page, $alternativeContext);
Since the live page is hidden, $isHidden is always true. This propagates to PreviewSimulator which sets includeHiddenContent = true, disabling the HiddenRestriction for all content elements on that page.
Reviews 2
Related issues 5
- Bug #96658Frontend preview doesn't work on restricted pages, when any none-live-workspace is selected
- Bug #96778Workspace Preview Links not working when [starttime] in future
- Bug #108185Content element becomes visible when both page and element are disabled
- Task #108718Revert: Consider starttime/endtime for versioned records
- Bug #110602Prevent TypoScript-->Functions-->cache poisoning by Page-Preview
History 916
-
Gerrit Code Review pushed patch set 1 for main to change 92590 status
NewUnder Review <span data-processor="relativetime" data-value="2026-01-30T14:48:38+00:00" > 01/30/26, 14:48 </span> -
Gerrit Code Review pushed patch set 2 for main to change 92590 <span data-processor="relativetime" data-value="2026-01-30T15:11:53+00:00" > 01/30/26, 15:11 </span>
-
Garvin Hicking changed Related to #96778 <span data-processor="relativetime" data-value="2026-01-30T17:05:18+00:00" > 01/30/26, 17:05 </span>
-
Garvin Hicking changed Related to #96658 <span data-processor="relativetime" data-value="2026-01-30T17:05:32+00:00" > 01/30/26, 17:05 </span>
-
Garvin Hicking changed Related to #108185 <span data-processor="relativetime" data-value="2026-01-30T17:05:43+00:00" > 01/30/26, 17:05 </span>
-
Garvin Hicking changed Related to #108718 <span data-processor="relativetime" data-value="2026-01-30T17:05:52+00:00" > 01/30/26, 17:05 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 92590 <span data-processor="relativetime" data-value="2026-02-04T12:47:04+00:00" > 02/04/26, 12:47 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 92590 <span data-processor="relativetime" data-value="2026-04-22T06:40:40+00:00" > 04/22/26, 06:40 </span>
-
Ayke Halder changed Related to #110602 <span data-processor="relativetime" data-value="2026-09-02T12:48:24+00:00" > 09/02/26, 12:48 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 92590 <span data-processor="relativetime" data-value="2026-11-09T21:28:58+00:00" > 11/09/26, 21:28 </span>
-
Benni Mack commented <span data-processor="relativetime" data-value="2026-11-09T21:37:24+00:00" > 11/09/26, 21:37 </span>
The root cause described here, PreviewSimulator enabling includeHiddenContent, no longer exists on main. It was removed by the revert in #108718 (40935ba54ec), so hidden content elements in a workspace are no longer forced visible through this path.
One related problem remains in PageRepository::checkIfPageIsHidden(). A page that is hidden in live but visible in the workspace was still reported as hidden. The PreviewSimulator then enabled includeHiddenPages for the whole workspace preview, so other hidden pages appeared in menus and rootlines.
Patch set 5 of https://review.typo3.org/c/Packages/TYPO3.CMS/+/92590 rebases the change onto main. It now looks only at the workspace version of the page, or at the live page if there is no workspace version. It also adds a functional test covering the live/workspace combinations, and no longer throws a TypeError for a missing page in a workspace.
If you can still reproduce hidden content elements showing up in a workspace preview on current main, please add the steps here.
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 97549 <span data-processor="relativetime" data-value="2026-11-11T15:36:06+00:00" > 11/11/26, 15:36 </span>
-
Amir Arends commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-11-11T15:40:12+00:00" > 11/11/26, 15:40 </span>Applied in changeset commit:9e0b1af4ed55931513856954841702893bac4eea.
-
Gerrit Code Review pushed patch set 2 for 14.3 to change 97549 status
ResolvedUnder Review <span data-processor="relativetime" data-value="2026-11-11T15:46:22+00:00" > 11/11/26, 15:46 </span> -
Amir Arends commented and changed status
Under ReviewResolved <span data-processor="relativetime" data-value="2026-11-11T16:00:13+00:00" > 11/11/26, 16:00 </span>Applied in changeset commit:98a00ee7be205eec7e71c3fe7ae87797787da3a7.
Code snippet is already reverted with this commit:
https://github.com/TYPO3/typo3/commit/40935ba54ec2b1ac65290576dc1229d92cb14448