Review 12.4 Merged

92618[TASK] Update PHPStan to 2.1.38

Garvin Hicking CR +2 V +2 Easy +10 −15 updated 02/01/26, 17:57

Commit message

Bugfix versions of PHPStan were released as a follow-up
to address the `@param-out` issue (among others) that
came up in #108697 (2.1.35, 2.1.36, 2.1.37, 2.1.38).

With this, `@param-out` can be introduced again.

Type hints are adapted to prevent a new baseline entry.

Executed commands:

    composer req --dev phpstan/phpstan:^2.1.38 -W
   ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 6

Review log 57

  1. Garvin Hicking commented on patch set 1 02/01/26, 17:19

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.json * composer.lock
  2. Garvin Hicking uploaded patch set 2 02/01/26, 17:22

  3. core-ci voted on patch set 1 V -1 02/01/26, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94770

  4. core-ci voted on patch set 2 V +1 02/01/26, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94771

  5. Garvin Hicking marked it ready for review 02/01/26, 17:56

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 02/01/26, 17:56

  7. Garvin Hicking merged patch set 3 02/01/26, 17:57