Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
92677[FEATURE] Make dashboard widgets resizable
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/92677/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/92677/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Georg Ringer +1
-
Verified V -1 Blocked
- Benjamin Franzke -1
- Georg Ringer +1
- Peter Kraume +1
- core-ci +1 CI
Relation chain 2
-
main
92700[BUGFIX] Use correct data attribute for modals
The chain has patch set 2 of 3, the changes above it need a rebase.
-
92677 [FEATURE] Make dashboard widgets resizable This change
Issues 1
Files 6
- Build/Sources/Sass/dashboard/_grid.scss+5 −0
- Build/Sources/Sass/dashboard/_widget.scss+15 −0
- Build/Sources/TypeScript/dashboard/dashboard.ts+342 −9
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108869-MakeDashboardWidgetsResizable.rstnew+22 −0
- typo3/sysext/dashboard/Resources/Public/Css/dashboard.css+3 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/dashboard.js+1 −1
Review log 2130
Show 35 earlier messages
-
Andreas Nedbal uploaded patch set 1 02/05/26, 09:40
-
Andreas Nedbal updated the commit message in patch set 2 02/05/26, 09:41
-
core-ci voted on patch set 2 V -1 02/05/26, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95121
-
Andreas Nedbal rebased onto patch set 3
V -102/05/26, 16:21The following files contain Git conflicts: * typo3/sysext/dashboard/Resources/Public/JavaScript/dashboard.js -
core-ci voted on patch set 3 V -1 02/05/26, 17:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95183
-
Andreas Nedbal uploaded patch set 4
V -102/05/26, 17:27 -
Andreas Nedbal marked it ready for review 02/05/26, 17:27
-
Andreas Nedbal uploaded patch set 5 02/05/26, 17:36
-
core-ci voted on patch set 4 V +1 02/05/26, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95192
-
core-ci voted on patch set 5 V +1 02/05/26, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95196
-
Andreas Nedbal uploaded patch set 6
V +102/05/26, 20:30 -
core-ci voted on patch set 6 V -1 02/05/26, 20:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95210
-
core-ci voted on patch set 6 V +1 02/05/26, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95210
-
Andreas Nedbal uploaded patch set 7
V +102/06/26, 10:12 -
core-ci voted on patch set 7 V +1 02/06/26, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95259
-
Peter Kraume commented on patch set 7 V +1 02/06/26, 10:30
Feature is functional as described with mouse and keyboard. Frontend code review is out of my scope unfortunately. But I really like the feature! -
Andreas Kienast commented on patch set 7 02/06/26, 10:51
I didn't checkout the patch by myself yet, but I just wanted to raise some awareness. Does this patch allow pre-defining a widget size in the preset configuration, e.g. in https://review.typo3.org/c/Packages/TYPO3.CMS/+/92331/6/typo3/sysext/sys_note/Configuration/Backend/DashboardPresets.php? -
Andreas Nedbal commented on patch set 7 02/06/26, 11:48
Reply
It doesn't. I thought about the whole ordeal of preconfigured sizes, min and max sizes as well, but I decided to keep it simple with just the core functionality as of now (but I can of course add that here if requested, otherwise I'd suggest followups for that) -
Garvin Hicking uploaded patch set 8
V +102/06/26, 13:02 -
Garvin Hicking commented on patch set 8 02/06/26, 13:03
Sorry accidental relation chain push, dont mind this pls :( -
core-ci voted on patch set 8 V +1 02/06/26, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95287
-
Garvin Hicking uploaded patch set 9
V +102/06/26, 16:26fix accidental revert to earlier patchset -
Garvin Hicking commented on patch set 9 02/06/26, 16:29
Hhm. Dragging/Resizing now is fluent, but I don't understand the blue borders. They seem to light up sometimes, but if I let go of the resizing then, it snaps at a completely different place than where the borders flashed. Also somehow when I resize a widget, the ones below it 'wiggle around' even though I only change the horizontal axis. Sent you a video. -
core-ci voted on patch set 9 V +1 02/06/26, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95327
-
Andreas Nedbal commented on patch set 9 02/06/26, 16:43
Reply
The border flash happens when the next snap threshold has been hit, signalling "if you release now, it will snap to the next size in that direction". Changing that logic to be exactly when a snap point is hit shouldn't be a problem though. There's probably more things wrong in terms of UX so I'll wait on some more feedback before adjusting this. -
Peter Kraume voted on patch set 9 V +1 02/07/26, 07:28
-
Georg Ringer commented on patch set 9 CR +1 V +1 02/07/26, 09:17
I just don't like the icon, IMHO it is not 100% correct -
Benjamin Franzke commented on patch set 9 V -1 02/07/26, 10:30
Hi, I noticed some usability problems: * The resize icon is not understandable. Resizing is possible vertically and horizontically, but the icon depicts a vertical orientation only. * Since resizing snaps to defined grids, a user would expect to see the snap-target while resizing. Similar to the target that is shown when performing drag'n'drop guesture. * During resize, the widgets sometimes hide behind other widgets (The resized widget needs to be temporary"leveled" up in terms of z-index during resize) -
Benjamin Franzke commented on patch set 9 02/07/26, 10:31
Reply
* Other elements change size, while the widget is resized. The grid should stay consistent during resize. Or do you see a technical limitation? -
Simon Schaufelberger commented on patch set 9 03/05/26, 20:43
Reply Unresolved
@andy@pixelde.su will you take care about these issues? Would be great!