Review main Work in progress Orphaned

92686[WIP][TASK] Color Contrast Ratio Checker

Benjamin Kott CR 0 V -1 Normal +173 −0 updated 02/06/26, 06:41

Commit message

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/92686/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/92686/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Relation chain 2

  1. 92686 [WIP][TASK] Color Contrast Ratio Checker This change

  2. main 92666[TASK] Introduce decorative state color tokens adding lime and indigo This change is based on it Merged Benjamin Kott CR +2 V +2 Hard +287 −59

    The chain has patch set 2 of 3, the changes above it need a rebase.

Files 3

Review log 45

  1. Benjamin Kott uploaded patch set 1 02/05/26, 14:51

  2. Benjamin Kott marked it work in progress 02/05/26, 14:52

  3. Benjamin Franzke commented on patch set 1 02/05/26, 14:59

    color-contrast-ratio-element.ts:107 Unresolved

    Can we show `N/A` for `rgba` values for now? Otherwise we'd need to traverse parents and calculate the real color.
  4. core-ci voted on patch set 1 V -1 02/05/26, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95165

  5. Mathias Brodala commented on patch set 1 02/06/26, 06:41

    color-contrast-ratio-element.ts:138 Unresolved

    I wonder if there is a 3rd party library which could be used instead.