Review 13.4 Merged

92728[BUGFIX] Add title from image properties only when not set via argument

Georg Ringer CR +2 V +2 Easy +10 −4 updated 02/06/26, 17:00

Commit message

When trying to display an image without an alt-attribute
`alt=""` can be set as a ViewHelper attribute.
On the other hand, trying to display an image without a title-attribute
is not possible with setting `title=""`.
It will result in trying to fallback to the title stored
within the image properties.

Only trying to set the title-attribute from the image-properties when
the additional ViewHelper attribute is not set solves this issue.

As the HTML `title` attribute is not explicitly necessary,
it can be fully omitted.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 02/06/26, 16:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/06/26, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95329

  3. Georg Ringer voted on patch set 1 CR +2 V +2 02/06/26, 17:00

  4. Georg Ringer merged patch set 2 02/06/26, 17:00