Review 13.4 Abandoned

92740[BUGFIX] Prevent language inheritance in form finishers

Benni Mack CR 0 V -1 Normal +139 −49 updated 02/13/26, 11:21

Commit message

This fix removes the languageKey property from the TranslationService.
Since the service is a singleton, an overridden translation language
in one finisher was being inherited by subsequent finishers.

To retain the ability to translate emails consistently in a specific language using the existing option, the TranslateElementPropertyViewHelper has been extended with a new languageKey argument.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 2

Files 5

Review log 45

  1. Benni Mack commented on patch set 1 02/07/26, 16:55

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php * typo3/sysext/form/Classes/Service/TranslationService.php * typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php * typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.fluid.html * typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.fluid.txt
  2. Benni Mack commented on patch set 1 02/07/26, 16:56

    TranslationService.php:461

    we should keep the methods (I guess it won't hurt)
  3. core-ci voted on patch set 1 V -1 02/07/26, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95383

  4. Josua Vogel commented on patch set 1 02/10/26, 08:56

    TranslationService.php:461 Reply Unresolved

    What would you expect when calling the methods? The property languageKey has been removed in this patch (problem with singleton) and could no longer be returned.
  5. Benni Mack abandoned the change 02/13/26, 11:21

    won'T do