92740[BUGFIX] Prevent language inheritance in form finishers
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 2
Files 5
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+6 −8
- typo3/sysext/form/Classes/Service/TranslationService.php2+57 −41
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php+5 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.fluid.htmlnew+52 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.fluid.txtnew+19 −0
Review log 45
-
Benni Mack commented on patch set 1 02/07/26, 16:55
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php * typo3/sysext/form/Classes/Service/TranslationService.php * typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php * typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.fluid.html * typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.fluid.txt -
Benni Mack commented on patch set 1 02/07/26, 16:56
TranslationService.php:461we should keep the methods (I guess it won't hurt) -
core-ci voted on patch set 1 V -1 02/07/26, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95383
-
Josua Vogel commented on patch set 1 02/10/26, 08:56
TranslationService.php:461Reply UnresolvedWhat would you expect when calling the methods? The property languageKey has been removed in this patch (problem with singleton) and could no longer be returned. -
Benni Mack abandoned the change 02/13/26, 11:21
won'T do