Review main Merged

92741[TASK] Compare file endings in image processing test

André Buchmann CR +2 V +2 Easy +16 −4 updated 02/11/26, 20:18

Commit message

Image processing utilizes a fallback chain if certain formats
couldn't be written by the image processor.

The image processing tests now show a warning if the output format
doesn't match the expected format.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1725

  1. André Buchmann uploaded patch set 1 02/07/26, 20:54

  2. core-ci voted on patch set 1 V +1 02/07/26, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95386

  3. Garvin Hicking commented on patch set 1 CR +1 02/08/26, 09:03

    Looking good, need to verify later. Thanks!

    EnvironmentController.php:1374

    ```suggestion if ($fileExtReference !== '' && $fileExtOutput !== '' && $fileExtReference !== $fileExtOutput) { ``` (We try to avoid empty() magicness in favor of strict comparisons. Untested if this still works or if these teo can be null)
  4. Garvin Hicking commented on patch set 1 02/08/26, 13:09

    EnvironmentController.php:1376

    Maybe we can rewrite this with something like "a fallback format is used which may not be the desired output."
  5. André Buchmann uploaded patch set 2 CR +1 V +1 02/10/26, 08:41

  6. core-ci voted on patch set 2 V -1 02/10/26, 08:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95527

  7. André Buchmann uploaded patch set 3 V -1 02/10/26, 09:16

  8. core-ci voted on patch set 3 V -1 02/10/26, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95529

  9. André Buchmann commented on patch set 2 02/10/26, 09:45

    EnvironmentController.php:1374 Reply

    The variables are no initialized with null and I replaced !empty() with is_string() && !=='' to have it type safe for the later comparison as we only want to compare file extension strings and end() returns mixed.

    EnvironmentController.php:1376 Reply

    I reduced it from error to warning and clarified that a fallback format is used. Should we also include a hint for the user to run `convert -list format` for more details? Or is this to specific to ImageMagick?
  10. core-ci voted on patch set 3 V +1 02/10/26, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95529

  11. Garvin Hicking commented on patch set 3 02/10/26, 11:41

    EnvironmentController.php:1376 Reply

    Could idea, how about the suggestion?

    EnvironmentController.php:1379

    ```suggestion . ' Please verify that ImageMagick / GraphicsMagick and your system provide the required codec libraries to write ' . strtoupper($fileExtReference) . ' files, for example by checking the output of a "convert -list format" shell command.', ```
  12. André Buchmann uploaded patch set 4 V +1 02/10/26, 21:43

  13. André Buchmann commented on patch set 4 02/10/26, 21:46

    EnvironmentController.php:1376 Reply

    I like the suggestion. Thx

    EnvironmentController.php:1379 Reply

    Acknowledged
  14. core-ci voted on patch set 4 V +1 02/10/26, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95576

  15. Garvin Hicking updated the commit message in patch set 5 V +1 02/11/26, 07:02

  16. Garvin Hicking commented on patch set 5 CR +1 V +1 02/11/26, 07:03

    We can't do this for 12.4 as this is no high-impact change or needed for the infra, hope that's fine with you too. Thanks a lot!
  17. André Buchmann commented on patch set 5 02/11/26, 07:34

    Reply

    I thought in combination with the IM7 patch it would make sense to add this to all supported versions. The IM7 patch should have implemented years ago xD But im fine to have this for main & 13 only
  18. core-ci voted on patch set 5 V -1 02/11/26, 07:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95598

  19. Garvin Hicking updated the commit message in patch set 6 CR +1 V +1 02/11/26, 08:25

  20. core-ci voted on patch set 6 V +1 02/11/26, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95602

  21. Anja Leichsenring updated the commit message in patch set 7 V +1 02/11/26, 19:44

  22. Anja Leichsenring commented on patch set 7 CR +1 V +1 02/11/26, 19:48

    looks good, and I have no strong oppinion on v12. Might not hurt in combination with the IM7 patch.
  23. core-ci voted on patch set 7 V +1 02/11/26, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95647

  24. Garvin Hicking commented on patch set 7 CR +2 V +2 02/11/26, 19:53

    Reply

    I see your point there, yes. Let me think/discuss about it.
  25. Garvin Hicking merged patch set 8 02/11/26, 20:18