92741[TASK] Compare file endings in image processing test
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Garvin Hicking +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1725
-
André Buchmann uploaded patch set 1 02/07/26, 20:54
-
core-ci voted on patch set 1 V +1 02/07/26, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95386
-
Garvin Hicking commented on patch set 1 CR +1 02/08/26, 09:03
Looking good, need to verify later. Thanks!EnvironmentController.php:1374```suggestion if ($fileExtReference !== '' && $fileExtOutput !== '' && $fileExtReference !== $fileExtOutput) { ``` (We try to avoid empty() magicness in favor of strict comparisons. Untested if this still works or if these teo can be null) -
Garvin Hicking commented on patch set 1 02/08/26, 13:09
EnvironmentController.php:1376Maybe we can rewrite this with something like "a fallback format is used which may not be the desired output." -
André Buchmann uploaded patch set 2
CR +1V +102/10/26, 08:41 -
core-ci voted on patch set 2 V -1 02/10/26, 08:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95527
-
André Buchmann uploaded patch set 3
V -102/10/26, 09:16 -
core-ci voted on patch set 3 V -1 02/10/26, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95529
-
André Buchmann commented on patch set 2 02/10/26, 09:45
EnvironmentController.php:1374ReplyThe variables are no initialized with null and I replaced !empty() with is_string() && !=='' to have it type safe for the later comparison as we only want to compare file extension strings and end() returns mixed.EnvironmentController.php:1376ReplyI reduced it from error to warning and clarified that a fallback format is used. Should we also include a hint for the user to run `convert -list format` for more details? Or is this to specific to ImageMagick? -
core-ci voted on patch set 3 V +1 02/10/26, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95529
-
Garvin Hicking commented on patch set 3 02/10/26, 11:41
EnvironmentController.php:1376ReplyCould idea, how about the suggestion?EnvironmentController.php:1379```suggestion . ' Please verify that ImageMagick / GraphicsMagick and your system provide the required codec libraries to write ' . strtoupper($fileExtReference) . ' files, for example by checking the output of a "convert -list format" shell command.', ``` -
André Buchmann uploaded patch set 4
V +102/10/26, 21:43 -
André Buchmann commented on patch set 4 02/10/26, 21:46
EnvironmentController.php:1376ReplyI like the suggestion. ThxEnvironmentController.php:1379ReplyAcknowledged -
core-ci voted on patch set 4 V +1 02/10/26, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95576
-
Garvin Hicking updated the commit message in patch set 5
V +102/11/26, 07:02 -
Garvin Hicking commented on patch set 5 CR +1 V +1 02/11/26, 07:03
We can't do this for 12.4 as this is no high-impact change or needed for the infra, hope that's fine with you too. Thanks a lot! -
André Buchmann commented on patch set 5 02/11/26, 07:34
Reply
I thought in combination with the IM7 patch it would make sense to add this to all supported versions. The IM7 patch should have implemented years ago xD But im fine to have this for main & 13 only -
core-ci voted on patch set 5 V -1 02/11/26, 07:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95598
-
Garvin Hicking updated the commit message in patch set 6
CR +1V +102/11/26, 08:25 -
core-ci voted on patch set 6 V +1 02/11/26, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95602
-
Anja Leichsenring updated the commit message in patch set 7
V +102/11/26, 19:44 -
Anja Leichsenring commented on patch set 7 CR +1 V +1 02/11/26, 19:48
looks good, and I have no strong oppinion on v12. Might not hurt in combination with the IM7 patch. -
core-ci voted on patch set 7 V +1 02/11/26, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95647
-
Garvin Hicking commented on patch set 7 CR +2 V +2 02/11/26, 19:53
Reply
I see your point there, yes. Let me think/discuss about it. -
Garvin Hicking merged patch set 8 02/11/26, 20:18