92743[BUGFIX] Make Extbase identity map language-aware
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Anja Leichsenring +1
- Mathias Brodala +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Anja Leichsenring +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/14.2/Important-93765-ExtbaseIdentityMapNowLanguageAware.rstnew+37 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+30 −5
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php4+23 −7
- typo3/sysext/extbase/Classes/Persistence/Generic/PersistenceManager.php+1 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Session.php2+51 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+6 −35
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/SessionTest.php+118 −0
Review log 1519
-
Benni Mack uploaded patch set 1 02/08/26, 12:43
-
core-ci voted on patch set 1 V +1 02/08/26, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95407
-
Benni Mack uploaded patch set 2
V +102/08/26, 13:18 -
core-ci voted on patch set 2 V +1 02/08/26, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95410
-
Mathias Brodala commented on patch set 2 02/09/26, 06:55
Backend.php:183This should be moved to the top again and only the $languageAspect fetched before. Updating the query settings should be skipped if we don't use them afterwards.Session.php:181Since this is only used here we should move it from LanguageAspect. -
Benni Mack uploaded patch set 3
V +102/12/26, 17:01 -
Benni Mack commented on patch set 3 02/12/26, 17:02
This change is ready for review.Backend.php:183Replywe need the language aspect, so I needed to keep it below here, but the query does not need to be updated (so I moved it below)Session.php:181ReplyDone -
Benni Mack commented on patch set 3 02/12/26, 17:02
LanguageAspect.php:143ReplyDone -
core-ci voted on patch set 3 V +1 02/12/26, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95757
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 02/12/26, 19:42
-
Mathias Brodala commented on patch set 3 02/13/26, 07:02
Backend.php:183ReplyStill setRespectStoragePage() and setRespectSysLanguage() are called without effect in case the session knows the object. So this should be moved down, too. -
Benni Mack commented on patch set 4
CR +1V +102/13/26, 07:30Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 02/13/26, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95804
-
Mathias Brodala commented on patch set 4 CR +1 02/13/26, 07:50
Backend.php:183ReplyDone -
Anja Leichsenring voted on patch set 4 CR +1 V +1 02/13/26, 19:13
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 02/25/26, 23:52
-
Oliver Klee voted on patch set 4 V +1 02/26/26, 10:50
-
Benni Mack commented on patch set 4 CR +2 V +2 02/26/26, 10:58
thanks! -
Benni Mack merged patch set 5 02/26/26, 10:58
LanguageAspect.php:143