Review 13.4 Merged

92753[BUGFIX] Use correct form editor return URL after editing content element

Benni Mack CR +2 V +2 Normal +58 −6 updated 02/10/26, 08:47

Commit message

When editing a content element within the form editor preview mode
and closing it after saving, the system returned to the wrong URL,
causing a "Required argument 'formDefinition' is not set" exception.

The issue occurred because the content element's edit link used the
current request URI as return URL, which pointed back to the preview
rendering endpoint.

This change fixes the issue by:

* Passing formPersistenceIdentifier through the rendering chain
* TypeScript: Send persistenceIdentifier in AJAX request
* Controller: Accept formPersistenceIdentifier parameter and set it
  as rendering option
* Fluid: Pass formPersistenceIdentifier to ViewHelper
* ViewHelper: Generate correct return URL to FormEditor->index
  with formPersistenceIdentifier parameter using UriBuilder
* Request manipulation: Override NormalizedParams to customize
  the return URL used by PageLayoutContext

The return URL now correctly points to the form editor with the
appropriate formPersistenceIdentifier, ensuring users can close
content element editing and return seamlessly to their form.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 813

  1. Benni Mack commented on patch set 1 02/09/26, 13:34

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Classes/ViewHelpers/Be/RenderContentElementPreviewViewHelper.php * typo3/sysext/form/Resources/Private/Frontend/Partials/ContentElement.fluid.html
  2. core-ci voted on patch set 1 V -1 02/09/26, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95466

  3. Josua Vogel uploaded patch set 2 V -1 02/09/26, 19:57

  4. core-ci voted on patch set 2 V -1 02/09/26, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95488

  5. Josua Vogel commented on patch set 3 V -1 02/09/26, 21:14

    Published edit on patch set 2.
  6. Josua Vogel commented on patch set 4 02/09/26, 21:16

    Published edit on patch set 3.
  7. core-ci voted on patch set 3 V -1 02/09/26, 21:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95489

  8. core-ci voted on patch set 4 V +1 02/09/26, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95490

  9. Josua Vogel uploaded patch set 5 V +1 02/10/26, 08:37

  10. Benni Mack marked it ready for review 02/10/26, 08:44

  11. core-ci voted on patch set 5 V +1 02/10/26, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95526

  12. Benni Mack voted on patch set 5 CR +2 V +2 02/10/26, 08:47

  13. Benni Mack merged patch set 6 02/10/26, 08:47