Review 13.4 Merged

92803[BUGFIX] Add space for dialog close button label

Garvin Hicking CR +2 V +2 Easy +2 −2 updated 02/11/26, 20:13

Commit message

Using MacOS VoiceOver to read backend dialog close button label appears
to miss space between "Close" and following words (modalTitle).

Due to lit's rendering the space between button-close and modalTitle
disappears in the outputted template:
`<!--?lit$784970363$-->Close<!--?lit$784970363$-->Search`

The browser's accessibility tree will then interpret it as:
`Name: "CloseSearch"`

This is resolved by directly concatenating the space inside one template
 literal.

Commands executed:
  ./Build/Scripts/runTests.sh -s build

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Garvin Hicking commented on patch set 1 02/11/26, 19:54

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/modal.ts * typo3/sysext/backend/Resources/Public/JavaScript/modal.js
  2. Garvin Hicking uploaded patch set 2 02/11/26, 19:57

  3. Garvin Hicking marked it ready for review 02/11/26, 19:57

  4. core-ci voted on patch set 2 V +1 02/11/26, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95651

  5. Garvin Hicking voted on patch set 2 CR +2 V +2 02/11/26, 20:13

  6. Garvin Hicking merged patch set 3 02/11/26, 20:13