Review 13.4 Merged

92814[BUGFIX] Fix removeSysRedirectPermission wiping user permissions

Oli Bartsch CR +2 V +2 Normal +135 −2 updated 02/12/26, 12:22

Commit message

removeSysRedirectPermission() received the groupData
key name (e.g. "tables_select") but treated it as the
literal permission string instead of looking up the
actual value from $GLOBALS['BE_USER']->groupData.

This caused all existing table permissions to be
replaced with the key name string whenever a
temporarily added sys_redirect permission was
removed. This is fixed now and covered by tests.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 02/12/26, 11:40

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/12/26, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95706

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 02/12/26, 12:22

  4. Oli Bartsch merged patch set 2 02/12/26, 12:22