Review 12.4 Merged

92831[TASK] Create compatibility for ImageMagick 7

Garvin Hicking CR +2 V +2 Easy +7 −4 updated 02/12/26, 21:04

Commit message

ImageMagick 7 has removed the legacy "+matte" command line
operator, which was previously used to disable the alpha channel.
This causes image processing to produce incorrect outputs when
using newer versions of ImageMagick.

This patch replaces all occurrences of "+matte" with "-alpha off"
for ImageMagick, which is the modern equivalent supported by
ImageMagick 6/7.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Garvin Hicking commented on patch set 1 02/12/26, 20:09

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php * typo3/sysext/frontend/Classes/Imaging/GifBuilder.php
  2. Garvin Hicking uploaded patch set 2 02/12/26, 20:17

  3. core-ci voted on patch set 1 V -1 02/12/26, 20:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95773

  4. Garvin Hicking uploaded patch set 3 02/12/26, 20:19

  5. core-ci voted on patch set 3 V +1 02/12/26, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95775

  6. core-ci voted on patch set 2 V +1 02/12/26, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95774

  7. Garvin Hicking marked it ready for review 02/12/26, 21:03

  8. Garvin Hicking voted on patch set 3 CR +2 V +2 02/12/26, 21:04

  9. Garvin Hicking merged patch set 4 02/12/26, 21:04