Review 13.4 Merged

92930[BUGFIX] Fix extbase argument uploads merging

Garvin Hicking CR +2 V +2 Normal +223 −3 updated 02/20/26, 20:59

Commit message

Using array_merge_recursive for uploads in `RequestBuilder`
leads to issues when handling multidimensional arrays in
GET/POST parameters, as numeric keys get renumbered
instead of being replaced.

The correct behavior is to use array_replace_recursive,
which was the original approach removed in #97214 and
incorrectly restored as array_merge_recursive in
change #102283.

This change ensures that uploaded files are properly
merged into request parameters while preserving the
correct array structure, especially for deeply nested
and multidimensional arguments.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 02/20/26, 16:29

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/20/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96381

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 02/20/26, 20:59

  4. Garvin Hicking merged patch set 2 02/20/26, 20:59