Review 13.4 Merged

92968[TASK] Update PHPStan to v2.1.40

Garvin Hicking CR +2 V +2 Easy +16 −18 updated 02/24/26, 11:52

Commit message

Updates PHPStan to the latest version 2.1.40.

Changes to new PHPStan findings are fixed to prevent new
baseline additions.

Executed commands:

> Build/Scripts/runTests.sh -s composer -- \
      require --dev phpstan/phpstan:^2.1.40
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Garvin Hicking commented on patch set 1 02/24/26, 06:50

    Cherry Picked from branch main. The following files contain Git conflicts: * composer.json * composer.lock * typo3/sysext/backend/Classes/ElementBrowser/ElementBrowserParameters.php * typo3/sysext/core/Classes/Domain/Repository/PageRepository.php * typo3/sysext/redirects/Classes/Controller/RecordHistoryRollbackController.php
  2. core-ci voted on patch set 1 V -1 02/24/26, 07:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96673

  3. Garvin Hicking uploaded patch set 2 V -1 02/24/26, 07:01

    baseline
  4. Garvin Hicking marked it ready for review 02/24/26, 07:02

  5. core-ci voted on patch set 2 V +1 02/24/26, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96676

  6. Oliver Klee voted on patch set 2 CR +1 V +1 02/24/26, 08:28

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 02/24/26, 11:52

  8. Garvin Hicking merged patch set 3 02/24/26, 11:52