Review main Merged

92978[BUGFIX] Keep target and text in typolink BC path

Sebastian Michaelsen CR +2 V +2 Easy +24 −1 updated 02/24/26, 13:37

Commit message

Forwarding empty values in `AbstractTypolinkBuilder::_build()` broke legacy `build()` implementations in v14. Pass the provided link text and target through and cover it with a regression unit test.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1

Issues 1

Files 3

Review log 89

  1. Sebastian Michaelsen uploaded patch set 1 02/24/26, 12:56

  2. Oliver Klee voted on patch set 1 V +1 02/24/26, 12:59

  3. Oliver Klee commented on patch set 1 02/24/26, 13:01

    Should this also be backported to V14/V13?
  4. Sebastian Michaelsen commented on patch set 1 02/24/26, 13:05

    Reply

    I think main still means v14. That's the target version I have in mind. My fix itself doesn't make sense to be backported to v13. It's specific to v14 providing a backwards compatibility layer. The bug isn't there in v13.
  5. Oliver Klee updated the commit message in patch set 2 V +1 02/24/26, 13:08

  6. Oliver Klee voted on patch set 2 CR +1 V +1 02/24/26, 13:08

  7. Benni Mack commented on patch set 2 CR +2 V +2 02/24/26, 13:17

    Thank you, Sebastian. Was my bad!
  8. Benni Mack merged patch set 3 02/24/26, 13:17

  9. core-ci voted on patch set 1 V +1 02/24/26, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96731