#109086Backwards-compatibility for AbstractTypolinkBuilder doesn't support $linkText and $target
Description
public function _build(array &$linkDetails, string $linkText, string $target, array $conf, ServerRequestInterface $request, ContentObjectRenderer $contentObjectRenderer): LinkResultInterface
{
// ...
// This one is in order to keep BC for v14 as we avoid adding the abstract method "build" to implement by subclasses
if (method_exists($this, 'build')) {
return $this->build($linkDetails, '', '', $conf);
}
// ...
}
The two '' values that are passed to $this->build() are meant to be the $linkText and $target. We have those available anyway and if we pass them down then the code that relies on that BC-layer still works with link text and target.
Reviews 1
History 35
-
Sebastian Michaelsen changed subject
Backwards-compatibility for AbstractTypolinkBuilder doesn't suport $linkText and $targetBackwards-compatibility for AbstractTypolinkBuilder doesn't support $linkText and $target <span data-processor="relativetime" data-value="2026-02-24T12:40:34+00:00" > 02/24/26, 12:40 </span> -
Gerrit Code Review pushed patch set 1 for main to change 92978 status
NewUnder Review <span data-processor="relativetime" data-value="2026-02-24T12:56:18+00:00" > 02/24/26, 12:56 </span> -
Gerrit Code Review pushed patch set 2 for main to change 92978 <span data-processor="relativetime" data-value="2026-02-24T13:08:48+00:00" > 02/24/26, 13:08 </span>
-
Sebastian Michaelsen commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-02-24T13:20:09+00:00" > 02/24/26, 13:20 </span> -
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2026-03-31T08:11:36+00:00" > 03/31/26, 08:11 </span>
Applied in changeset commit:b1fe4acc5e47adbeb7e6a2797db200d7ea893e0d.