Review 13.4 Merged

92986[BUGFIX] Fix recycler pagination with multiple record types

Benni Mack CR +2 V +2 Normal +144 −2 updated 02/24/26, 19:54

Commit message

DeletedRecords was registered as a shared service, so all
GeneralUtility::makeInstance() calls within a single request
returned the same instance. Since loadData() and getTotalCount()
both append to internal arrays ($deletedRows, $table) without
resetting them, the second call accumulated state from the first.

This caused getTotalCount() to return wildly inflated values
(e.g. 53 instead of 9), making the paginator show phantom empty
pages and rendering records from prior calls on each page.

We fix this by marking DeletedRecords as a non-shared
service so each makeInstance() call returns a fresh instance.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benni Mack commented on patch set 1 02/24/26, 19:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/24/26, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96775

  3. Benni Mack voted on patch set 1 CR +2 V +2 02/24/26, 19:54

  4. Benni Mack merged patch set 2 02/24/26, 19:54