Review 13.4 Merged

93052[TASK] Enable EnvironmentStatusReport for CLI

Garvin Hicking CR +2 V +2 Easy +15 −3 updated 03/04/26, 08:40

Commit message

Having the EnvironmentStatusReport disabled for CLI
makes the report scheduler task useless.

This patch allows to utilize the extended checks.

An important differentiation is that the environment
in CLI can be different from the Web configuration,
and certain variables are not available in CLI context
($_SERVER mostly).

This patch excludes these specific checks, and
should catch all places where this superglobal is accessed.

Additionally, to make recipients of the CLI-context based
report aware of possible differences between PHP configuration
on CLI and web context, a small disclaimer is added to
the email.

The new language service system has been utilized in the
places this touches.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 69

  1. Garvin Hicking commented on patch set 1 03/04/26, 05:42

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php * typo3/sysext/reports/Resources/Private/Language/locallang_reports.xlf
  2. core-ci voted on patch set 1 V -1 03/04/26, 05:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97251

  3. Garvin Hicking uploaded patch set 2 V -1 03/04/26, 07:43

    adapt backport
  4. Garvin Hicking uploaded patch set 3 03/04/26, 07:52

    adjust LLL syntax
  5. Garvin Hicking marked it ready for review 03/04/26, 07:52

  6. core-ci voted on patch set 2 V -1 03/04/26, 07:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97264

  7. core-ci voted on patch set 3 V +1 03/04/26, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97267

  8. Garvin Hicking voted on patch set 3 CR +2 V +2 03/04/26, 08:40

  9. Garvin Hicking merged patch set 4 03/04/26, 08:40