Review 13.4 Merged

93056[BUGFIX] Handle non-string keys in implodeAttributes

Christian Kuhn CR +2 V +2 Easy +7 −1 updated 03/04/26, 09:11

Commit message

Cast attribute keys to string before normalizing case in
GeneralUtility::implodeAttributes().

Malformed attribute lists can contain integer array keys (for example
from broken ATagParams parsing with unescaped quotes and numeric
tokens), which previously caused a TypeError in strtolower().

Valid string attribute keys keep their existing behavior. Non-string
keys are normalized to string instead of causing a fatal error.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn commented on patch set 1 03/04/26, 08:57

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/04/26, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97278

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 03/04/26, 09:11

  4. Christian Kuhn merged patch set 2 03/04/26, 09:11