Review 13.4 Merged

93136[TASK] Prevent redundant hmac calculation in EXT:felogin password reset

Garvin Hicking CR +2 V +2 Easy +4 −2 updated 03/10/26, 13:29

Commit message

When resetting the password in felogin, it is not necessary to create
the hmac twice. The computation can be performed once to save
resources.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Garvin Hicking commented on patch set 1 03/10/26, 08:58

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php
  2. Garvin Hicking commented on patch set 2 03/10/26, 09:02

    Published edit on patch set 1.
  3. Garvin Hicking marked it ready for review 03/10/26, 09:03

  4. core-ci voted on patch set 2 V +1 03/10/26, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97655

  5. core-ci voted on patch set 1 V -1 03/10/26, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97654

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 03/10/26, 13:29

  7. Garvin Hicking merged patch set 3 03/10/26, 13:29