93144[BUGFIX] Properly persist ENV variables in site config (rootPageId)
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
-
Verified V +2 Done
- Garvin Hicking +2
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+9 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+13 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteDatabaseEditRow.php+9 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php+26 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSiteLanguage.php+8 −1
- typo3/sysext/backend/Tests/Functional/Configuration/EnvPlaceholderProcessorTest.phpnew+70 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+49 −48
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteDatabaseEditRowTest.php+8 −7
- typo3/sysext/core/Classes/Configuration/Loader/YamlFileLoader.php+1 −0
- typo3/sysext/core/Classes/Configuration/Processor/Placeholder/EnvPlaceholderProcessor.phpnew+130 −0
Review log 69
-
Garvin Hicking commented on patch set 1 03/10/26, 13:11
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php * typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php * typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSiteLanguage.php * typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php -
core-ci voted on patch set 1 V -1 03/10/26, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97696
-
Garvin Hicking commented on patch set 2
V -103/10/26, 13:18Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 03/10/26, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97699
-
Garvin Hicking commented on patch set 3
V +103/10/26, 14:02Published edit on patch set 2. -
Garvin Hicking marked it ready for review 03/10/26, 14:06
-
core-ci voted on patch set 3 V +1 03/10/26, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97702
-
Garvin Hicking voted on patch set 3 CR +2 V +2 03/10/26, 14:14
-
Garvin Hicking merged patch set 4 03/10/26, 14:14