Review 13.4 Merged

93241[BUGFIX] Use strict empty check for HTTP header values

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 03/18/26, 06:25

Commit message

!empty($value) incorrectly skips HTTP headers whose value is
a falsy non-empty string such as "0". This has been replaced
with a strict string comparison $value !== '' to ensure such
headers are included when building the server request.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 03/18/26, 05:16

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/18/26, 05:19

  3. core-ci voted on patch set 1 V +1 03/18/26, 05:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98135

  4. Benjamin Franzke merged patch set 2 03/18/26, 06:25