Review main Ready for review

93303[BUGFIX] Create sys_file_metadata translation on demand

Sebastian Michaelsen CR 0 V 0 Normal +196 −17 updated 11/11/26, 10:43

Commit message

Since #82178, the edit-metadata link of a file reference in a
non-default language is only rendered when a localized
sys_file_metadata record already exists. Editors therefore
cannot edit the metadata of a file that has never been
localized before, unless they create the translation in the
file list module first.

FileReferenceContainer now creates the missing translation
from the default-language record via MetaDataRepository
right before rendering the link, so the edit-metadata link
is always available.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 5
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/03/93303/5 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/03/93303/5 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 6

Issues 2

Files 7

Review log 813

  1. Sebastian Michaelsen uploaded patch set 1 03/22/26, 09:32

  2. core-ci voted on patch set 1 V -1 03/22/26, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98379

  3. Sebastian Michaelsen uploaded patch set 2 V -1 03/23/26, 11:47

  4. core-ci voted on patch set 2 V +1 03/23/26, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98464

  5. Riccardo De Contardi commented on patch set 2 V +1 03/23/26, 14:22

    seems to work: when I edited the metatada of the file from the reference (e.g. [description]), it used the correct language
  6. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 06:43

  7. core-ci voted on patch set 3 V +1 04/22/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100775

  8. Sebastian Michaelsen uploaded patch set 4 V +1 09/30/26, 09:13

  9. core-ci voted on patch set 4 V +1 09/30/26, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109604

  10. Oliver Klee voted on patch set 4 V +1 09/30/26, 10:20

  11. Simon Schaufelberger commented on patch set 4 10/02/26, 22:18

    FileReferenceContainerTest.php:35 Unresolved

    do we need the global variable or would a local variable be sufficient?
  12. Benni Mack uploaded patch set 5 V +1 11/11/26, 10:04

  13. core-ci voted on patch set 5 V +1 11/11/26, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114043