Review 12.4 Merged

93341[TASK] Update PHPStan to v2.1.43

Garvin Hicking CR +2 V +2 Easy +6 −30 updated 03/24/26, 23:40

Commit message

Updates PHPStan to the latest version 2.1.43.

New PHPStan version no longer reports two false
negatives.

Executed commands:

> Build/Scripts/runTests.sh -s composer -- \
      require --dev phpstan/phpstan:^2.1.43
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Garvin Hicking commented on patch set 1 03/24/26, 21:26

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.json * composer.lock
  2. Garvin Hicking uploaded patch set 2 03/24/26, 21:32

  3. Garvin Hicking marked it ready for review 03/24/26, 21:32

  4. core-ci voted on patch set 1 V -1 03/24/26, 21:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98625

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 03/24/26, 21:39

  6. core-ci voted on patch set 2 V +1 03/24/26, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98627

  7. Oliver Klee voted on patch set 2 CR +1 V +1 03/24/26, 22:25

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 03/24/26, 23:40

  9. Christian Kuhn merged patch set 3 03/24/26, 23:40