93397[FEATURE] Add generic TranslatorInterface
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 21
- typo3/sysext/backend/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/core/Classes/Localization/LanguageService.php+60 −7
- typo3/sysext/core/Classes/Localization/LanguageServiceFactory.php2+10 −0
- typo3/sysext/core/Classes/Localization/TranslatorInterface.phpnew+88 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-89334-AddGenericTranslatorInterface.rst8new+112 −0
- typo3/sysext/core/Tests/Functional/Localization/LanguageServiceTest.php+154 −0
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+7 −9
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/FlagValueViewHelper.php+3 −3
- typo3/sysext/indexed_search/Classes/FileContentParser.php+42 −52
- typo3/sysext/indexed_search/Resources/Private/Partials/Form.fluid.html+12 −12
- typo3/sysext/indexed_search/Resources/Private/Partials/Pagination.fluid.html+3 −3
- typo3/sysext/indexed_search/Resources/Private/Partials/Searchresult.fluid.html+4 −4
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/ExternalDocuments.fluid.html+15 −15
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Index.fluid.html+15 −15
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Pages.fluid.html+17 −17
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Statistic.fluid.html+19 −19
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/StatisticDetails.fluid.html+20 −20
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/WordDetail.fluid.html+9 −9
- typo3/sysext/indexed_search/Resources/Private/Templates/Search/NoTypoScript.fluid.html+1 −1
- typo3/sysext/indexed_search/Resources/Private/Templates/Search/Search.fluid.html+7 −7
Review log 1317
-
Benni Mack uploaded patch set 1 03/27/26, 12:19
-
core-ci voted on patch set 1 V +1 03/27/26, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98862
-
Benni Mack uploaded patch set 2
V +103/27/26, 12:41 -
core-ci voted on patch set 2 V -1 03/27/26, 12:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98866
-
Benjamin Franzke commented on patch set 2 03/27/26, 13:11
❤️LanguageServiceFactory.php:58Comment about "dependency injection" is outdated. -
Benni Mack uploaded patch set 3
V -103/27/26, 16:10 -
Benni Mack commented on patch set 3 03/27/26, 16:10
LanguageServiceFactory.php:58ReplyDone -
Benjamin Franzke voted on patch set 3 CR +1 03/27/26, 16:18
-
core-ci voted on patch set 3 V -1 03/27/26, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98896
-
Garvin Hicking commented on patch set 3 03/27/26, 18:32
Feature-89334-AddGenericTranslatorInterface.rst:92```suggestion * `my_extension.messages:my.key` ```Feature-89334-AddGenericTranslatorInterface.rst:93```suggestion * `EXT:my_extension/Resources/Private/Language/locallang.xlf:my.key` ```Feature-89334-AddGenericTranslatorInterface.rst:94```suggestion * `LLL:EXT:my_extension/Resources/Private/Language/locallang.xlf:my.key` ```Feature-89334-AddGenericTranslatorInterface.rst:96```suggestion The `LLL:` prefix is optional and stripped before resolution. ``` Just a question: the double quotes come from Claude, yes? Because I see this very often now. Or do we have a helper tool that uses this syntax we try to avoid? -
Benni Mack uploaded patch set 4
CR +1V -103/27/26, 18:39 -
Garvin Hicking voted on patch set 4 CR +1 03/27/26, 18:45
-
core-ci voted on patch set 4 V +1 03/27/26, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98910
-
Garvin Hicking commented on patch set 4 V +1 03/27/26, 18:48
Feature-89334-AddGenericTranslatorInterface.rst:92ReplyDoneFeature-89334-AddGenericTranslatorInterface.rst:93ReplyDoneFeature-89334-AddGenericTranslatorInterface.rst:94ReplyDoneFeature-89334-AddGenericTranslatorInterface.rst:96ReplyDone -
Benjamin Franzke voted on patch set 4 CR +1 V +1 03/27/26, 20:10
-
Benni Mack voted on patch set 4 CR +2 V +2 03/27/26, 20:30
-
Benni Mack merged patch set 5 03/27/26, 20:30