Review 13.4 Merged

93421[TASK] Improve naming in MvcPropertyMappingConfigurationServiceTest

Garvin Hicking CR +2 V +2 Easy +22 −22 updated 03/28/26, 17:57

Commit message

Variables holding an instance of `MvcPropertyMappingConfigurationService`
are named `$requestHashService`, which is misleading and incorrect.

With this change, all affected variables to
`$mvcPropertyMappingConfigurationService` are changed to
reflect the actual class being instantiated.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 03/28/26, 17:41

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/28/26, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98966

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 03/28/26, 17:56

  4. Garvin Hicking merged patch set 2 03/28/26, 17:57