Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
93476[TASK] Apply configured indentation to `*.neon` files
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/76/93476/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/76/93476/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 2
-
93476 [TASK] Apply configured indentation to `*.neon` files This change
-
main
93475[TASK] Use `rawMessage` in PHPStan baseline
The chain has patch set 1 of 5, the changes above it need a rebase.
Files 3
Review log 56
-
Elias Häußler uploaded patch set 1 03/31/26, 05:48
-
core-ci voted on patch set 1 V +1 03/31/26, 06:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99214
-
Stefan Bürk commented on patch set 1 03/31/26, 08:59
I'd rather adjust the editorconfig than reformatting the files. -
Elias Häußler commented on patch set 1 04/07/26, 14:02
Reply
That'd mean, we'd need to update it here as well, to be in line with the core configuration, right? https://github.com/TYPO3/coding-standards/blob/5b0f6d8cca856f4da04dcdf18ff6d4d4d55b4d2b/templates/editorconfig.dist#L36-L39 -
Stefan Bürk commented on patch set 1 04/07/26, 14:24
Reply Unresolved
For me that's a dedicated/side project originally managed by Gilli which is not there anymore. Never used it anyway, we use (adopting) core diretly instead of that package. On the other hand - we are talking here about core development and not what other things should do or not like in that cases - for "non - product" files not shipped at all and only part of the mono-repository ... TBH I never cared about that package, was never suitable for our projects and extensions personally and for the company ... sure, can be adopted or not. -
Benni Mack marked it work in progress 04/22/26, 07:29