Review main Merged

93519[TASK] Use `TranslatorInterface` in `ResultRenderingTrait`

Benjamin Franzke CR +2 V +2 Easy +16 −17 updated 04/08/26, 06:59

Commit message

Use the implementation agnostic `TranslatorInterface` as introduced
in #89334 instead of `LanguageService` in `ResultRenderingTrait`.

Since `LanguageService` implements `TranslatorInterface`,
nothing changes for consumers of this trait, but allows to
use the generic interface from now on.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1521

  1. Benjamin Franzke uploaded patch set 1 04/02/26, 07:20

  2. core-ci voted on patch set 1 V -1 04/02/26, 07:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99443

  3. Benjamin Franzke uploaded patch set 2 V -1 04/02/26, 07:45

  4. Chris Müller commented on patch set 2 04/02/26, 07:50

    LabelBag.php:44

    tanslater -> translater
  5. Benjamin Franzke uploaded patch set 3 04/02/26, 07:52

  6. Benjamin Franzke commented on patch set 3 04/02/26, 07:52

    LabelBag.php:44 Reply

    thx!
  7. Benjamin Franzke uploaded patch set 4 04/02/26, 07:53

  8. Benjamin Franzke wrote 04/02/26, 07:54

    Hashtag added: actions
  9. core-ci voted on patch set 2 V -1 04/02/26, 07:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99445

  10. core-ci voted on patch set 4 V -1 04/02/26, 08:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99448

  11. core-ci voted on patch set 4 V +1 04/02/26, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99448

  12. Oliver Klee commented on patch set 4 04/02/26, 11:28

    ResultRenderingTrait.php:40

    typo: tanslator -> translator
  13. Benjamin Franzke uploaded patch set 5 V +1 04/02/26, 11:33

  14. Benjamin Franzke commented on patch set 5 04/02/26, 11:33

    ResultRenderingTrait.php:40 Reply

    ugh, did the same mistake twice 🤦‍♂️ Thx, fixed!
  15. core-ci voted on patch set 5 V +1 04/02/26, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99473

  16. Oliver Klee updated the commit message in patch set 6 V +1 04/02/26, 11:44

  17. core-ci voted on patch set 6 V +1 04/02/26, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99475

  18. Garvin Hicking voted on patch set 6 CR +1 V +1 04/04/26, 17:41

  19. Josua Vogel voted on patch set 6 CR +1 V +1 04/07/26, 06:08

  20. Benjamin Franzke voted on patch set 6 CR +2 V +2 04/08/26, 06:59

  21. Benjamin Franzke merged patch set 7 04/08/26, 06:59