Review main Merged

93572[BUGFIX] Bring back accidentally removed MFA setup in user settings

Garvin Hicking CR +2 V +2 Normal +77 −31 updated 04/12/26, 14:09

Commit message

With #108880 the user settings were modified to be TCA based. Several
special elements were provided earlier:

- Password/password2 fields
- avatar field
- calendar start day
- language dropdown
- backend start module
- MFA setup

The MFA setup information was replaced by utilizing the existing
'mfaInfo' TCA form element rendering. This however was fixed to
react to `be_users` and `fe_users` only, and not `be_users_settings`.

Additionally, prior code to evaluate a non-existing MFA setup
was missing.

This patch brings back that information.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1826

Show 1 earlier messages
  1. Garvin Hicking uploaded patch set 1 04/08/26, 18:35

  1. Christian Kuhn commented on patch set 1 04/08/26, 18:39

    MfaInfoElement.php:142

    whats to solve here?
  2. Garvin Hicking commented on patch set 1 04/08/26, 18:42

    MfaInfoElement.php:142 Reply

    I just copy+pasted the prior contents in here and tried to remedy this. The display of this does not really look great to me though so I could need help to properly align this. I never used MFA properly so I'm not really designated to be great at restoring this. 😄
  3. Garvin Hicking uploaded patch set 2 04/08/26, 18:46

  4. core-ci voted on patch set 1 V -1 04/08/26, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99791

  5. core-ci voted on patch set 2 V -1 04/08/26, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99793

  6. Garvin Hicking uploaded patch set 3 V -1 04/08/26, 19:59

  7. core-ci voted on patch set 3 V -1 04/08/26, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99796

  8. core-ci commented on patch set 3 04/08/26, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99796

  9. core-ci commented on patch set 3 04/08/26, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99796

  10. Josua Vogel commented on patch set 3 CR -1 04/09/26, 07:47

    on it
  11. Josua Vogel uploaded patch set 4 CR -1 V -1 04/09/26, 08:04

  12. core-ci voted on patch set 4 V -1 04/09/26, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99823

  13. Josua Vogel uploaded patch set 5 V -1 04/09/26, 09:00

  14. core-ci voted on patch set 5 V +1 04/09/26, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99830

  15. Josua Vogel commented on patch set 5 04/09/26, 09:38

    Reply

    Done
  16. Garvin Hicking commented on patch set 5 04/09/26, 11:03

    Reply

    Thank you. This looks okay to me. Still a bit redundant information ("Setup mfa" is active, but a large red disabled button for not being allowed to remove an admins MFA), but I don't know how to better deal with it.

    MfaInfoElement.php:142 Reply

    Done
  17. Josua Vogel voted on patch set 5 CR +1 V +1 04/09/26, 15:44

  18. Benni Mack commented on patch set 5 04/12/26, 11:33

    MfaInfoElement.php:126

    we need to change this from EXT:setup to EXT:backend
  19. Benni Mack uploaded patch set 6 CR +1 V +1 04/12/26, 11:36

  20. Benni Mack commented on patch set 6 04/12/26, 11:37

    MfaInfoElement.php:126 Reply

    Done
  21. core-ci voted on patch set 6 V +1 04/12/26, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100017

  22. Benni Mack voted on patch set 6 CR +1 V +1 04/12/26, 13:46

  23. Josua Vogel voted on patch set 6 CR +1 V +1 04/12/26, 14:00

  24. Garvin Hicking voted on patch set 6 CR +2 V +2 04/12/26, 14:09

  25. Garvin Hicking merged patch set 7 04/12/26, 14:09