93572[BUGFIX] Bring back accidentally removed MFA setup in user settings
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Josua Vogel +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Josua Vogel +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1826
Show 1 earlier messages
-
Garvin Hicking uploaded patch set 1 04/08/26, 18:35
-
Christian Kuhn commented on patch set 1 04/08/26, 18:39
-
Garvin Hicking commented on patch set 1 04/08/26, 18:42
MfaInfoElement.php:142ReplyI just copy+pasted the prior contents in here and tried to remedy this. The display of this does not really look great to me though so I could need help to properly align this. I never used MFA properly so I'm not really designated to be great at restoring this. 😄 -
Garvin Hicking uploaded patch set 2 04/08/26, 18:46
-
core-ci voted on patch set 1 V -1 04/08/26, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99791
-
core-ci voted on patch set 2 V -1 04/08/26, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99793
-
Garvin Hicking uploaded patch set 3
V -104/08/26, 19:59 -
core-ci voted on patch set 3 V -1 04/08/26, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99796
-
core-ci commented on patch set 3 04/08/26, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99796
-
core-ci commented on patch set 3 04/08/26, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99796
-
Josua Vogel commented on patch set 3 CR -1 04/09/26, 07:47
on it -
Josua Vogel uploaded patch set 4
CR -1V -104/09/26, 08:04 -
core-ci voted on patch set 4 V -1 04/09/26, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99823
-
Josua Vogel uploaded patch set 5
V -104/09/26, 09:00 -
core-ci voted on patch set 5 V +1 04/09/26, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99830
-
Josua Vogel commented on patch set 5 04/09/26, 09:38
Reply
Done -
Garvin Hicking commented on patch set 5 04/09/26, 11:03
Reply
Thank you. This looks okay to me. Still a bit redundant information ("Setup mfa" is active, but a large red disabled button for not being allowed to remove an admins MFA), but I don't know how to better deal with it.MfaInfoElement.php:142ReplyDone -
Josua Vogel voted on patch set 5 CR +1 V +1 04/09/26, 15:44
-
Benni Mack commented on patch set 5 04/12/26, 11:33
MfaInfoElement.php:126we need to change this from EXT:setup to EXT:backend -
Benni Mack uploaded patch set 6
CR +1V +104/12/26, 11:36 -
Benni Mack commented on patch set 6 04/12/26, 11:37
MfaInfoElement.php:126ReplyDone -
core-ci voted on patch set 6 V +1 04/12/26, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100017
-
Benni Mack voted on patch set 6 CR +1 V +1 04/12/26, 13:46
-
Josua Vogel voted on patch set 6 CR +1 V +1 04/12/26, 14:00
-
Garvin Hicking voted on patch set 6 CR +2 V +2 04/12/26, 14:09
-
Garvin Hicking merged patch set 7 04/12/26, 14:09
MfaInfoElement.php:142