#109521MFA Setup from User Settings is broken
Description
With refactoring of #108880 the user settings MFA setup was removed and replaced with the “mfaInfo” Element.
That Element however is lacking several functions that the old MFA code had in typo3/sysext/setup/Classes/Controller/SetupModuleController.php:
case 'mfa':
$label = $this->getLabel($config['label'] ?? '');
$html = '';
$lang = $this->getLanguageService();
$hasActiveProviders = $this->mfaProviderRegistry->hasActiveProviders($backendUser);
if ($hasActiveProviders) {
if ($this->mfaProviderRegistry->hasLockedProviders($backendUser)) {
$html .= ' <span class="badge badge-danger">' . htmlspecialchars($lang->sL('LLL:EXT:setup/Resources/Private/Language/locallang.xlf:mfaProviders.lockedMfaProviders')) . '</span>';
} else {
$html .= ' <span class="badge badge-success">' . htmlspecialchars($lang->sL('LLL:EXT:setup/Resources/Private/Language/locallang.xlf:mfaProviders.enabled')) . '</span>';
}
}
$html .= '<div class="formengine-field-item t3js-formengine-field-item">';
$html .= '<div class="form-description">' . nl2br(htmlspecialchars($lang->sL('LLL:EXT:setup/Resources/Private/Language/locallang.xlf:mfaProviders.description'))) . '</div>';
if (!$this->mfaProviderRegistry->hasProviders()) {
$html .= '<span class="badge badge-danger">' . htmlspecialchars($lang->sL('LLL:EXT:setup/Resources/Private/Language/locallang.xlf:mfaProviders.notAvailable')) . '</span>';
break;
}
$html .= '<div class="form-group"><div class="form-group"><div class="form-control-wrap t3js-file-controls">';
$html .= '<a href="' . htmlspecialchars((string)$this->uriBuilder->buildUriFromRoute('mfa')) . '" class="btn btn-default">';
$html .= htmlspecialchars($lang->sL('LLL:EXT:setup/Resources/Private/Language/locallang.xlf:mfaProviders.' . ($hasActiveProviders ? 'manageLinkTitle' : 'setupLinkTitle')));
$html .= '</a>';
$html .= '</div></div></div></div>';
break;
- The MfaInfo Element is only suitable for
be_usersandfe_userstables notbe_users_settings - It does not show a “setup MFA” link
- It does not iterate locked providers
- It does not check for active providers